Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSOSolvers for Krylov 0.8 #115

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Update JSOSolvers for Krylov 0.8 #115

merged 1 commit into from
Apr 8, 2022

Conversation

amontoison
Copy link
Member

No description provided.

@amontoison
Copy link
Member Author

amontoison commented Apr 7, 2022 •
edited
Loading

@abelsiqueira @tmigot
Do you want to keep Julia 1.3 ?
Krylov.jl only works for Julia >= 1.6 now.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Package name latest stable
Percival.jl

@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #115 (85264e7) into main (64d3671) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files           6        6           
  Lines         812      812           
=======================================
  Hits          691      691           
  Misses        121      121
Impacted Files Coverage Δ
src/trunk.jl 75.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d3671...85264e7. Read the comment docs.

@tmigot
Copy link
Member

tmigot commented Apr 7, 2022

@abelsiqueira @tmigot Do you want to keep Julia 1.3 ? Krylov.jl only works for Julia >= 1.6 now.

Hi @amontoison, thanks for this PR.
Can you make a separate PR dropping Julia 1.3?

@tmigot tmigot mentioned this pull request Apr 7, 2022
Merged
@tmigot tmigot self-requested a review April 7, 2022 12:20
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Package name latest stable
Percival.jl

tmigot
tmigot approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abelsiqueira abelsiqueira merged commit 97215c9 into JuliaSmoothOptimizers:main Apr 8, 2022
@abelsiqueira
Copy link
Member

Thank you

@tmigot tmigot mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amontoison @tmigot @abelsiqueira