Remove matrix-product with the structure only

[tmigot]

I let:

jac_op!(nlp, x, rows, cols, Jv, Jtv)
hess_op!(nlp, x, rows, cols, Hv; obj_weight=1.0)
hess_op!(nlp, x, y, rows, cols, Hv; obj_weight=1.0)

and

jac_op_residual!(nls, x, rows, cols, Jv, Jtv)

in case initializing LinearOperators benefit from the structure.

[codecov]

Codecov Report

Merging #382 (603fd0b) into main (f8ed18a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files          13       13              
  Lines         587      563      -24     
==========================================
- Hits          585      561      -24     
  Misses          2        2              

Impacted Files	Coverage Δ
src/nlp/api.jl	100.00% <ø> (ø)
src/nls/api.jl	100.00% <ø> (ø)
src/nlp/meta.jl	100.00% <0.00%> (ø)
src/nlp/show.jl	100.00% <0.00%> (ø)
src/nls/utils.jl	100.00% <0.00%> (ø)
src/nlp/counters.jl	100.00% <0.00%> (ø)
src/nls/counters.jl	100.00% <0.00%> (ø)
src/nlp/utils.jl	95.65% <0.00%> (+0.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ed18a...603fd0b. Read the comment docs.

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsModifiers.jl
NLPModelsTest.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverCore.jl
SolverTest.jl
SolverTools.jl

[tmigot]

@dpo @abelsiqueira it's trickier than expected to know if any of this is useful because it is tested in NLPModelsTest.jl. So, all the packages using these tests fail.

[abelsiqueira]

But at least we know that Percival and DCISolver don't need it.

[abelsiqueira]

We can update NLPModelsTest removing the test before this.

[dpo]

in case initializing LinearOperators benefit from the structure.

I don't think it's the case. IMO, those should be removed too.

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsModifiers.jl
NLPModelsTest.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverCore.jl
SolverTest.jl
SolverTools.jl

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsModifiers.jl
NLPModelsTest.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverCore.jl
SolverTest.jl
SolverTools.jl

[tmigot]

I prepared the two PR to fix the breakage of AmplNLReader.jl and NLPModelsModifiers.jl, so this can be reviewed.

[dpo]

lgtm

[abelsiqueira]

Thank you!