Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matrix-product with the structure only #30

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Nov 16, 2021

This is connected to PR 382 in NLPModels.jl

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #30 (7ddc807) into main (63d89d0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.02%     
==========================================
  Files          24       24              
  Lines        2492     2453      -39     
==========================================
- Hits         2471     2432      -39     
  Misses         21       21              
Impacted Files Coverage Δ
src/nls/check-dimensions.jl 100.00% <ø> (ø)
src/nls/consistency.jl 99.31% <ø> (-0.05%) ⬇️
src/nlp/consistency.jl 99.50% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d89d0...7ddc807. Read the comment docs.

@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@abelsiqueira
Copy link
Member

Any suggestions on why it's failing on 1.3?

@tmigot
Copy link
Member Author

tmigot commented Nov 19, 2021

Any suggestions on why it's failing on 1.3?

Apparently, the bug comes from nlp/consistency.jl and in particular this part: dcce6e0

However, I am not sure to see why this is failing

@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@abelsiqueira abelsiqueira merged commit 38a0d11 into main Nov 22, 2021
@abelsiqueira abelsiqueira deleted the rmv-jprod-struct branch November 22, 2021 20:29
@abelsiqueira
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants