Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build.jl #70

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Refactor build.jl #70

merged 2 commits into from
Jun 28, 2019

Conversation

omus
Copy link
Collaborator

@omus omus commented Jun 26, 2019

Inspired by the build.jl from ImageMagick.jl. In order to address the proxy support issue I decided to commit the dependency build files as a work around.

Fixes: #69

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   13.33%   13.33%           
=======================================
  Files           2        2           
  Lines          75       75           
=======================================
  Hits           10       10           
  Misses         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1222a0...edab293. Read the comment docs.

The `Base.download` function isn't working behind a proxy currently so
we'll use the `BinaryProvider.download` function instead.
@omus omus changed the title WIP: Refactor build.jl Refactor build.jl Jun 28, 2019
@omus
Copy link
Collaborator Author

omus commented Jun 28, 2019

No longer keeping a committed copy of the deps files due to BinaryProvider.download working correctly with proxies

@omus omus merged commit 24bb311 into master Jun 28, 2019
@omus omus deleted the cv/include-deps-files branch June 28, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibCURL does not build behind a proxy
2 participants