Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected server error view #352

Closed
vapaj opened this issue May 6, 2020 · 5 comments · Fixed by #373
Closed

Unexpected server error view #352

vapaj opened this issue May 6, 2020 · 5 comments · Fixed by #373
Assignees
Labels

Comments

@vapaj
Copy link
Member

vapaj commented May 6, 2020

Add view for an unexpected non-user-related error that we don't know how to recover from, like not getting a proper Product as a prop.

@vapaj vapaj added the vetrina label May 6, 2020
@ae-mo
Copy link
Contributor

ae-mo commented May 7, 2020

Could we reuse the error view we already have and do case analysis on the type of error maybe?

@vapaj
Copy link
Member Author

vapaj commented May 7, 2020

Absolutely!

@ae-mo ae-mo self-assigned this May 11, 2020
@ae-mo
Copy link
Contributor

ae-mo commented May 11, 2020

Do we need a different message from the one we are using now in the error view?

@vapaj
Copy link
Member Author

vapaj commented May 11, 2020

I suppose, as this is not a user related error. Currently we are saying:
"Something went wrong with your purchase. Try again or contact customer service."

It's not exactly the case here.

@ae-mo
Copy link
Contributor

ae-mo commented May 13, 2020

Resume (my understanding): we need to make the vetrina react component accept some JSX from the embedding code, so that it is rendered in case of failure in parsing the product list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants