Add G.R.A.P.E.F.R.U.I.T from SpaceDock #9855

netkan-bot · 2023-11-22T13:31:39Z

This pull request was automatically generated by SpaceDock on behalf of Dawn0303, to add G.R.A.P.E.F.R.U.I.T to CKAN.

Please direct questions about this pull request to Dawn0303.

Mod details

Key	Value
Name	G.R.A.P.E.F.R.U.I.T
Authors	Dawn0303
Abstract	[WIP] Adds parts that allow you to convert empty tanks into luxury habitats
License	CC-BY-NC-SA
Size	68.55 MiB
Homepage	https://forum.kerbalspaceprogram.com/topic/220714-wip-grapefruit-formerlytankhabs-help-wanted/
Source code	https://github.com/dawn0303/GRAPEFRUIT

Description

Gateway Residence for Astronauts Providing Enhanced Facilities for Researching and Understanding Interstellar Travel
[HELP WANTED]

This mod is designed to add parts that allow you to convert empty tanks into luxury habitats, heavily inspired by the Space Shuttle External Tank Station concept

this mod is still heavily WIP, you can find the roadmap Here

currently looking for someone who can help me make a module for the parts as i lack the ability right now, message me on TWT or the ksp forums if youre interested in helping!

This is an automated commit on behalf of Dawn0303

JonnyOThan · 2023-11-22T17:10:03Z

So this one is interesting because it bundles the HabUtils dll from SSPX. I don't know if this is a long-term approach, and I haven't investigated how it's being used yet. From talking to the author they are very concerned with limiting the dependencies of this mod, so we probably should not make SSPX a dependency here (but of course we could if there are no other solutions).

One solution would be to make HabUtils its own package in CKAN, and have GRAPEFRUIT and SSPX depend on it. Not sure if we'd need @ChrisAdderley's permission for that.

@dawn0303 could you provide some background info on how you're using HabUtils so we can make some informed decisions here?

dawn0303 · 2023-11-22T17:29:12Z

Basically, the mod just adds inflatable habs, and they all use the HabUtils to inflate, as the base game moduleAnimateGeneric was causing issues for others testing the mod, all of which HabUtils fixes.

the idea with packaging the DLL alone is that I didn't want to force people to have to also install all of SSPXr if they wanted to use my mod, and as the DLL is on the MIT licence I thought it would be ok.

it wasn't originally planned as a long-term approach as I would like my mod to have an original module, but I'm not certain if that will ever happen as it's something I would need a lot of help with.

if dependency is the only possible option I would be ok with that, but having the DLL be its own package would not only help this mod, but could be very helpful for future first-time modders

JonnyOThan · 2023-11-22T17:40:52Z

@dawn0303 are the problems you mentioned with ModuleAnimateGeneric limited to the IVAs not being created properly? I believe those are fixable in KSPCF (but of course that would add another dependency...), and you'd be waiting on whenever that patch gets written (KSPModdingLibs/KSPCommunityFixes#169). I suppose there's probably other benefits of using habutils as well (better integration with life support mods probably).

dawn0303 · 2023-11-22T17:52:59Z

yeah HabUtils is just a lot more versatile than even the fixed base game module, and life support mod integration is already in the works from some contributors

JonnyOThan · 2023-11-22T18:06:34Z

Trying to collect the set of options here. This is further complicated by the fact that SSPX manages its own metanetkan files.

Make GRAPEFRUIT depend on SSPX. No metadata changes needed, simple for users, but introduces a big dependency that isn't strictly required. Doesn't require any input from nertea.
Make a new HabUtils mod in CKAN, derived from the SSPX package. Make SSPX provide HabUtils and conflict with it (so you can only have one installed). This satisfies Dawn's desires to limit dependencies and doesn't require any input from nertea. It's a little more complicated for users, because if they have the standalone HabUtils and then want to install SSPX it will show up as a conflict. Users would also have to download the entire SSPX package just for the HabUtils dll (although it wouldn't be installed).
Same as option 2 except extract the HabUtils dll from the GRAPEFRUIT package or some new repository/release. Same benefits and drawbacks as option 2 and users won't have to download as much. However if the HabUtils in SSPX is ever updated, this package would also need to be. Unlikely in this case, but you never know.
Ask Nertea for permission to take ownership of SSPX's metadata into the netkan repository (or send him PRs for the metadata that he'd have to merge). Then make a new HabUtils netkan that extracts the dll from SSPX and make SSPX depend on it. This is cleaner from the user's point of view, though they'd still be downloading a lot just for this dll. Downside: requires nertea's involvement
Same as option 4 but fork HabUtils into its own repository (as in option 3). This addresses the download size concern. It's more complex for nertea if he ever wants to update HabUtils.

Did I miss anything? Thoughts?

dawn0303 · 2023-11-22T18:11:15Z

those seem like the best options yes, id say out of the list, 3 would make the most sense if nertea says no/doesnt respond, and 5 if nertea agrees

HebaruSan · 2023-11-22T18:15:34Z

Install everything from this mod for this module and make it conflict with SSPX
As 6, but test whether a conflict is actually needed, maybe it's safe to have both DLLs?

(I'm not a fan of either of these per se, just adding for completeness.)

JonnyOThan · 2023-11-22T18:16:18Z

Yep, didn't think of that one (6). simple, but pretty crappy for users.

dawn0303 · 2023-11-22T18:17:10Z

i was told both dlls would create issues, and I would prefer if it was playable alongside SSPXr, a hard dependently is preferable to a hard conflict

JonnyOThan · 2023-11-22T18:18:15Z

@dawn0303 would you mind investigating what happens if you have both? I do think ksp 1.12.2 or so introduced some protections against multiple DLL installs. So that might be an option if you limit compatibility with those versions.

There is a potential issue there if HabUtils is ever updated - presumably KSP will pick one of the two DLLs to load and ignore the other. I'm assuming that since GRAPEFRUIT is alphabetically earlier than SSPX, it will be grapefruit's version. But that's a pretty unlikely situation. And maybe we could address it by installing HabUtils into a different folder.

dawn0303 · 2023-11-22T18:18:42Z

will do!

dawn0303 · 2023-11-22T18:49:39Z

KSP.log
nevermind, from the looks of things there isn't an issue, maybe good to look over in case I missed something, but it seems to work fine, so may just bundle in the mainfolder

HebaruSan · 2023-11-22T18:53:44Z

Looks like NearFutureProps is also a dependency? I'll go ahead and add that, let us know if it shouldn't be.

dawn0303 · 2023-11-22T18:54:14Z

it definitely should be

JonnyOThan · 2023-11-22T18:54:28Z

Very interesting. The AssemblyLoader says that it loaded twice, and there's no extra output regarding duplicated DLLs or anything. But the MM assembly listing and the shabby patching records seem to indicate that there's only one instance loaded.

[LOG 18:34:55.849] Load(Assembly): SSPXrModuleOnly/Plugins/HabUtils
[LOG 18:34:55.849] AssemblyLoader: Loading assembly at E:\SteamLibrary\steamapps\steamapps\common\Kerbal Space Program\GameData\SSPXrModuleOnly\Plugins\HabUtils.dll
[LOG 18:34:55.850] Load(Assembly): StationPartsExpansionRedux/Plugins/HabUtils
[LOG 18:34:55.850] AssemblyLoader: Loading assembly at E:\SteamLibrary\steamapps\steamapps\common\Kerbal Space Program\GameData\StationPartsExpansionRedux\Plugins\HabUtils.dll
HabUtils v1.0.0.0
[LOG 18:35:08.101] [Shabby] Patching call site : HabUtils::VisualDebugUtils.DebugAxisTripod.CreateBasicRenderer
[LOG 18:35:08.104] [Shabby] Patching call site : HabUtils::VisualDebugUtils.DebugPoint.CreateBasicRenderer
[LOG 18:35:08.105] [Shabby] Patching call site : HabUtils::VisualDebugUtils.DebugLine.CreateBasicRenderer
[LOG 18:35:08.107] [Shabby] Patching call site : HabUtils::HabUtils.ModuleSimpleEditorTransparency.OnStart
  HabUtils                                1.0.0.0                  1.0.0.0                                           a2f59618ff1be2168281c4f42b1ab4228a8eebfd83f3500489d7fab8e6728ca0

I might want to take a look at the AssemblyLoader code to see what it's actually doing here, but this looks promising!

JonnyOThan · 2023-11-22T18:55:39Z

from a side conversation with Dawn. Is this still accurate?

"depends" : [
            { "name" : "NearFutureProps" },
            { "name" : "ModuleManager" }
        ],
        "recommends" : [
            { "name" : "FreeIva" }
        ],
        "suggests" : [
            { "name" : "ShuttleOrbiterConstructionKit" },
            { "name" : "ConnectedLivingSpace" },
            { "name" : "StationPartsExpansionRedux" }
        ]

dawn0303 · 2023-11-22T18:57:01Z

doesnt need the StationPartsExpansionRedux suggestion, if they work fine together and apart then I would probably leave it out

dawn0303 · 2023-11-22T18:57:43Z

for the next release i will probably move the DLL into the GRAPEFRUIT folder if it doesn't conflict

HebaruSan · 2023-11-22T18:59:04Z

I do think ksp 1.12.2 or so introduced some protections against multiple DLL installs. So that might be an option if you limit compatibility with those versions.

I believe the sequence was:

Originally it was OK to have duplicate DLLs, and the latest would be used
In KSP 1.12.0, a bug was introduced that caused the game to fail to load if there were duplicate DLLs
The bug was fixed in KSP 1.12.3

linuxgurugamer/QuickMods#18

So if somebody tries this on KSP 1.12.0–2, they might have issues, but they'll probably be having issues anyway.

JonnyOThan · 2023-11-22T18:59:37Z

So I wonder if we want to be proactive and still create a standalone HabUtils package...certainly don't have to do it now but it will benefit anyone who wants to do the same thing that GRAPEFRUIT is doing.

dawn0303 · 2023-11-22T19:05:03Z

definitely think it would be a good idea

HebaruSan · 2023-11-22T19:07:11Z

I think I'd prefer to get a sense of whether Nertea is willing to get involved before we act on that. If he's willing to play along, there's the potential to have a general purpose <18 KB download maintained by the original author.

dawn0303 · 2023-11-22T19:24:56Z

going to update the release to have the DLL bundled in the main folder

dawn0303 · 2023-11-22T19:31:24Z

all updated and bundled together!

HebaruSan

This looks pretty solid to me now. @JonnyOThan, I'll leave the merge to you in case you have any loose ends you'd like to tie up.

@dawn0303, after seeing how complicated and brittle some of this packaging/installation stuff can be, I hope it won't come as a surprise when I ask you to please let us know if you make any major changes to this mod, such as switching to a different plugin. We may have to evaluate options again to ensure things keep working. Thanks for the submission!

dawn0303 · 2023-11-22T19:42:42Z

definitely will do! changing modules is going to be when this mod goes into 1.0 so will be revamping everything

Add G.R.A.P.E.F.R.U.I.T from SpaceDock

bebf1a9

This is an automated commit on behalf of Dawn0303

netkan-bot added the Mod request label Nov 22, 2023

JonnyOThan added the Blocked on dependency label Nov 22, 2023

JonnyOThan added the Discussion needed label Nov 22, 2023

Try installing the HabUtils dll

e796c27

NFP dep

973f883

add recommends and suggests according to author

39e6ee1

The plugin is now in the main folder

cff2413

HebaruSan approved these changes Nov 22, 2023

View reviewed changes

JonnyOThan merged commit 93da9cb into master Nov 22, 2023
1 check passed

JonnyOThan deleted the add/GRAPEFRUIT branch November 22, 2023 20:32

JonnyOThan removed Discussion needed Blocked on dependency labels Nov 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add G.R.A.P.E.F.R.U.I.T from SpaceDock #9855

Add G.R.A.P.E.F.R.U.I.T from SpaceDock #9855

netkan-bot commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 •

edited

Loading

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023 •

edited

Loading

JonnyOThan commented Nov 22, 2023 •

edited

Loading

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 •

edited

Loading

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 •

edited by HebaruSan

Loading

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023 •

edited

Loading

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan left a comment •

edited

Loading

dawn0303 commented Nov 22, 2023

Add G.R.A.P.E.F.R.U.I.T from SpaceDock #9855

Add G.R.A.P.E.F.R.U.I.T from SpaceDock #9855

Conversation

netkan-bot commented Nov 22, 2023

Mod details

Description

JonnyOThan commented Nov 22, 2023 • edited Loading

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023 • edited Loading

JonnyOThan commented Nov 22, 2023 • edited Loading

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 • edited Loading

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 • edited by HebaruSan Loading

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023 • edited Loading

JonnyOThan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

dawn0303 commented Nov 22, 2023

HebaruSan left a comment • edited Loading

Choose a reason for hiding this comment

dawn0303 commented Nov 22, 2023

JonnyOThan commented Nov 22, 2023 •

edited

Loading

HebaruSan commented Nov 22, 2023 •

edited

Loading

JonnyOThan commented Nov 22, 2023 •

edited

Loading

JonnyOThan commented Nov 22, 2023 •

edited

Loading

JonnyOThan commented Nov 22, 2023 •

edited by HebaruSan

Loading

HebaruSan commented Nov 22, 2023 •

edited

Loading

HebaruSan left a comment •

edited

Loading