Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EL6 support and clean up #161

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Drop EL6 support and clean up #161

merged 4 commits into from
Jul 16, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 15, 2024 •
edited
Loading

  • drop EL6 support
  • drop last bits of EL5 testing
  • always test tracer

chris1984
chris1984 reviewed Jul 15, 2024
View reviewed changes
images/Dockerfile.el7 Outdated Show resolved Hide resolved
chris1984
chris1984 reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but looks fine once that duplicate change is out of there.

@evgeni
Copy link
Member Author

evgeni commented Jul 16, 2024

Yeah, it did contain #160 to see things still pass -- rebased now that 160 is merged.

@evgeni evgeni mentioned this pull request Jul 16, 2024
Merged
ekohl
ekohl approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also rebase #155 after this.

@ekohl ekohl merged commit d6a7ca6 into Katello:master Jul 16, 2024
6 of 8 checks passed
@evgeni evgeni deleted the c6ded branch July 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @chris1984