Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CentOS 10, Debian 11 and openSUSE 15 tests #162

Merged
merged 13 commits into from
Jul 16, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 16, 2024

  • don't set max-parallel 1, run all the tests in parallel
  • fail-fast: false - run all tests even if some fail
  • add EL10 testing
  • use native unittest, unittest2 was a backport for pre 2.7 python
  • stop using deprecated imp -- import and ImportError is enough
  • properly skip DNF related tests when DNF is not available
  • Add Debian 11 tests

@evgeni
Copy link
Member Author

evgeni commented Jul 16, 2024

EL6 is failing, but that will be removed in #161

@evgeni evgeni changed the title Add CentOS 10 and Debian 11 tests Add CentOS 10, Debian 11 and openSUSE 15 tests Jul 16, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some good cleanups here. I still think this repository has poor abstraction. Ideally we'd have some base class and then for each "backend" an implementation. Some changes I made in the past moved in this direction, but it's not there yet.

ZYPPER = True
except ImportError:
ZYPPER = False

try:
imp.find_module('yum')
import yum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change it to this, then this part becomes redundant:

if YUM:
import yum

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how so? it would then need to from katello.constants import yum instead…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, Ruby has created some brain damage where I assumed it was present in a global namespace.

@ekohl ekohl merged commit 3165eba into Katello:master Jul 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants