don't call SDL_DestroyRenderer or SDL_Quit until we get to gfx_sdl_destroy

[briaguya-ai]

soh testing pr: HarbourMasters/Shipwright#4172

in soh, quitting the game using the "Quit" option in the "Ship" menu was leading to garbage values in the config

this was happening because we call SaveWindowToConfig() in the Context destructor

libultraship/src/Context.cpp

Lines 26 to 28 in 6b8a8d8

	Context::~Context() {
	SPDLOG_TRACE("destruct context");
	GetWindow()->SaveWindowToConfig();

which makes calls to Get(Width/Height/PosX/PosY)

libultraship/src/window/Window.cpp

Lines 48 to 60 in 6b8a8d8

	void Window::SaveWindowToConfig() {
	// This accepts conf in because it can be run in the destruction of LUS.
	mConfig->SetBool("Window.Fullscreen.Enabled", IsFullscreen());
	if (IsFullscreen()) {
	mConfig->SetInt("Window.Fullscreen.Width", (int32_t)GetWidth());
	mConfig->SetInt("Window.Fullscreen.Height", (int32_t)GetHeight());
	} else {
	mConfig->SetInt("Window.Width", (int32_t)GetWidth());
	mConfig->SetInt("Window.Height", (int32_t)GetHeight());
	mConfig->SetInt("Window.PositionX", GetPosX());
	mConfig->SetInt("Window.PositionY", GetPosY());
	}
	}

which all call into mWindowManagerApi->get_dimensions

libultraship/src/graphic/Fast3D/Fast3dWindow.cpp

Lines 156 to 161 in 6b8a8d8

	uint32_t Fast3dWindow::GetWidth() {
	uint32_t width, height;
	int32_t posX, posY;
	mWindowManagerApi->get_dimensions(&width, &height, &posX, &posY);
	return width;
	}

which in SDL then calls SDL_GL_GetDrawableSize and SDL_GetWindowPosition

libultraship/src/graphic/Fast3D/gfx_sdl2.cpp

Lines 444 to 447 in 6b8a8d8

	static void gfx_sdl_get_dimensions(uint32_t* width, uint32_t* height, int32_t* posX, int32_t* posY) {
	SDL_GL_GetDrawableSize(wnd, static_cast<int*>((void*)width), static_cast<int*>((void*)height));
	SDL_GetWindowPosition(wnd, static_cast<int*>(posX), static_cast<int*>(posY));
	}

which gives us garbage if we've already called

    SDL_DestroyRenderer(renderer);
    SDL_Quit();

so, instead of directly calling these in gfx_sdl_close, we can rely on the fact that these get called when we destruct Fast3dWindow by calling gfx_destroy

libultraship/src/graphic/Fast3D/Fast3dWindow.cpp

Lines 35 to 38 in 6b8a8d8

	Fast3dWindow::~Fast3dWindow() {
	SPDLOG_DEBUG("destruct fast3dwindow");
	gfx_destroy();
	}

which in SDL land is gfx_sdl_destroy

libultraship/src/graphic/Fast3D/gfx_sdl2.cpp

Lines 606 to 611 in 6b8a8d8

	void gfx_sdl_destroy(void) {
	// TODO: destroy _any_ resources used by SDL
	SDL_DestroyRenderer(renderer);
	SDL_Quit();
	}