Fixes MahaanKoshTooltip Reading mode bug: #1741 + Prettier formatting #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JapnitS Great work 🔥 fixing this bug. Can we kindly remove this prettier formatting as we mostly relying on the VScode internal formatter so that we have similar formatting across the product. Rather I would propose to create another ticket to move the formatting to the prettier and we can do so in 1 formatting PR. |
gurjit03
requested changes
Sep 26, 2024
| <div | ||
| key={source} |
There was a problem hiding this comment.
@JapnitS here we are fixing the key to the spanish language ?
| )} | ||
| </div> | ||
| {/* Punjabi Translation Languages */} | ||
| <div |
There was a problem hiding this comment.
@JapnitS Lets create a small component named DisplayMixedViewBaani and use that here.
|
Closed in favor of #1743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm test& fixed newly introduced lint errors.Fixes bug #1741 by wrapping
BaaniLineinMahaanKoshContext.provider.Main logic diff pointer
Test snapshot change
Prettier formatting