-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding New Language (Persian) #152
Comments
Thank you. There is another file in the ModernWpf.MahApps project. For the existing languages I didn't actually translate anything—I try to get the translations from WinUI, and if they are not available, from the corresponding Windows language pack. This way we're consistent with Windows. The same can probably be done for Persian. I can do it if it's too much trouble. BTW is this a correct file for Persian 😅? |
Oh, so that's it😀 |
|
@ShankarBUS I'm sorry, but I do not have enough time to do this There are too many languages (68), Also, adding all languages is not a good thing in my opinion Every file must be modified for each change. It is very time consuming Unfortunately, Microsoft did not put all the resources in one file and the resource created each control separately. |
Regarding languages, build creates a bunch of folders in bin\release with ModernWpf.resources.dll in them. Is there a way to prevent this? |
@milos12345 you can write a PostBuild-Event in visual studio (Right Click Project and Properties\Build event) that delete extra folders each time you build
|
In theory, yes. In practice, adding a language can be time-consuming and error-prone, since currently the WinUI repo doesn’t contain all the required string resources. So initially I added only the languages that have corresponding string resources in .NET itself. The rest can be added as required. |
Could that be possible once WinUI 3 is open sourced |
Very likely. |
The SatelliteResourceLanguages MSBuild property also seems to work. |
If #202 were to be implemented, this would be a trivial task! |
Hello, thank you for your ModernWpf
If you agree, I wanted to add Persian language
Do I need to translate anything other than this file?
https://github.com/Kinnara/ModernWpf/blob/master/ModernWpf/Resources/Strings.resx
The text was updated successfully, but these errors were encountered: