-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the SatelliteResourceLanguages MSBuild property #18995
Comments
What's the status on documenting the I have many ASP.NET Core projects targeting
Adding the |
@stevenvolckaert note your spelling of the property, you have a typo there. It should be Also the version of Humanizer you're using is 6 years old. Any reason you haven't updated to a 2.x version that properly supports .NET Core and .NET Standard? |
Thanks for pointing this out @DamianEdwards! I tried again with correct spelling, and it works, both with Humanizer v1.33.7 and v2.11.10. (We've currently remained with v1.33.7 because there hasn't been an opportunity yet to upgrade.) However, this only works if Yesterday I added The @gewarren Because I see you've assigned this issue to yourself: Perhaps you'll find it useful to add this finding to the docs. It wasn't immediately obvious to me. Thanks a lot for your help @DamianEdwards! Much appreciated! 👌😎 |
Logged an issue to get this added to the MSBuild schema so it shows up in IntelliSense too: dotnet/msbuild#6854 |
In .NET Core 2.1 (SDK 2.1.300) we added support for specifying languages to preserve satellite resource assemblies for during publish. See dotnet/sdk#774 for details.
In a new .NET Core WinForms app, setting this property to "en-US" (the runtime's default language) will result in a saving of 15 MB on the size of the app when published self-contained. When combined with the
PublishTrimmed
flag, this is an ~18% size saving.Other packages commonly used in .NET Core apps (including ASP.NET Core, WinForms, and WPF apps) include embedded satellite resource assemblies that don't provide any benefit in cases where the app is only ever run in a single language context anyway.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: