Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ender 3 S1 Plus config & Fix max temp for S1 #5571

Closed
wants to merge 2 commits into from

Conversation

Fisheiyy
Copy link
Contributor

Signed-off-by: Rob Casper [email protected]

The Ender 3 S1 Plus has been released although I have yet to see any reviews over it or much talk but thought I might as well get the config added for when people do start to review it and talk about it (hopefully soon), I also fixed the max temperature for the hotend and bed for the S1 non-pro based off the official diagram on the Creality website.

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Jul 11, 2022
@Fisheiyy
Copy link
Contributor Author

@KevinOConnor

@KevinOConnor
Copy link
Collaborator

Configs need to be tested before merged into the master branch. It did not appear this PR was tested on the actual hardware.

-Kevin

@Fisheiyy
Copy link
Contributor Author

Configs need to be tested before merged into the master branch. It did not appear this PR was tested on the actual hardware.

-Kevin

Its the exact same config as the Ender 3 S1/S1 Pro configs with just a larger build volume so it shouldn't need testing, but eventually someone could probably test it, if you could re-open this PR and make sure the bot doesn't close it again that would be nice.

@Sungray
Copy link

Sungray commented Aug 1, 2022

I have a S1 Plus and I'd love a correct configuration. The one committed above doesn't seem right though, the Y cannot reach that high, it does a scary noise when calibrating like that. How can I help establish a correct configuration?

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Aug 1, 2022

I have a S1 Plus and I'd love a correct configuration. The one committed above doesn't seem right though, the Y cannot reach that high, it does a scary noise when calibrating like that. How can I help establish a correct configuration?

You can add me on discord so we can communicate quicker, and we can find the maximum movement of X and Y,
salmon man#1676

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Aug 1, 2022

Did a new commit, but PR is closed so it wont appear here, @KevinOConnor reopen this PR please.

@Fisheiyy Fisheiyy mentioned this pull request Aug 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants