Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ender 3 S1 Plus #5705

Merged
merged 13 commits into from
Sep 16, 2022
Merged

Add Ender 3 S1 Plus #5705

merged 13 commits into from
Sep 16, 2022

Conversation

Fisheiyy
Copy link
Contributor

Signed-off-by: Rob Casper [email protected]

Follow up PR to #5571

@Fisheiyy Fisheiyy changed the title Add Ender 3 S1 Plus config & Comment max temps for S1 Pro Add Ender 3 S1 Plus config & Change comments for S1 Pro Aug 11, 2022
@Fisheiyy Fisheiyy changed the title Add Ender 3 S1 Plus config & Change comments for S1 Pro Add Ender 3 S1 Plus, Fix comments & crashing for S1 Aug 18, 2022
@Fisheiyy Fisheiyy changed the title Add Ender 3 S1 Plus, Fix comments & crashing for S1 Add Ender 3 S1 Plus & Fix comments/crashing for S1 Aug 20, 2022
@KevinOConnor
Copy link
Collaborator

Thanks. The changes to the s1 config look fine to me.

I'm not sure about the addition of the "s1 plus" config. Please separate out the addition of s1-plus to a separate PR. I'd like to understand how much it differs from the existing "s1" config. Also, please confirm that config has been tested on the actual hardware, and please confirm that printer has the same issue with variable f103/f401 control boards.

-Kevin

@antiLegion
Copy link

I'm willing to test if needed. I have an Ender 3 S1 Plus.
My git skills are only beginner/intermediate though.

I attempted to flash the firmware yesterday but got stuck in boot/could never connect klipper to fluidd.
Had to go back to stock -- this could totally be user error though. I'm a veteran flasher of other firmwares, won't take me long to pick up. I am attempting a second time right now just to make sure I didn't bork something due to user error.

@Fisheiyy
Copy link
Contributor Author

Thanks. The changes to the s1 config look fine to me.

I'm not sure about the addition of the "s1 plus" config. Please separate out the addition of s1-plus to a separate PR. I'd like to understand how much it differs from the existing "s1" config. Also, please confirm that config has been tested on the actual hardware, and please confirm that printer has the same issue with variable f103/f401 control boards.

-Kevin

They are all under the S1 family so they all share the same general structure, which would include motherboard(s) and related variable MCU problems, the S1 Plus has a much larger print volume, I would argue its a change more worthy of its own config rather than the S1 Pro since that was just a maximum temperature change.

@Fisheiyy
Copy link
Contributor Author

I'm willing to test if needed. I have an Ender 3 S1 Plus. My git skills are only beginner/intermediate though.

I attempted to flash the firmware yesterday but got stuck in boot/could never connect klipper to fluidd. Had to go back to stock -- this could totally be user error though. I'm a veteran flasher of other firmwares, won't take me long to pick up. I am attempting a second time right now just to make sure I didn't bork something due to user error.

Check your MCU and flash accordingly, if you are trying to flash F103 firmware on a F401 it wont work.

@KevinOConnor
Copy link
Collaborator

Thanks. I have no strong preference for adding s1plus config. Please do separate it out to a separate PR though, and I need to see confirmation that it has been tested and is working on the actual hardware.

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Sep 1, 2022
@antiLegion
Copy link

I have successfully installed this on my Ender 3 S1 Plus.
It works.
I have only noted one odd issue.
When auto bed leveling, upon homing, and after beginning the 12 point leveling procedure, at point 4 the print head advances slightly too far and then violently corrects itself. Meaning that it adjust back the 1/2mm that it went too far, but it does so swiftly enough to cause what sounds like the head hitting the end of the track.

It only does this the first time after homing the axii.
I know this is probably difficult to understand from my description. Or maybe it is intended behavior. I am after all very new to 3D printing and a GitHub noob.

It did not do this on the stock firmware. Would a video help?

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Sep 5, 2022

I have successfully installed this on my Ender 3 S1 Plus. It works. I have only noted one odd issue. When auto bed leveling, upon homing, and after beginning the 12 point leveling procedure, at point 4 the print head advances slightly too far and then violently corrects itself. Meaning that it adjust back the 1/2mm that it went too far, but it does so swiftly enough to cause what sounds like the head hitting the end of the track.

It only does this the first time after homing the axii. I know this is probably difficult to understand from my description. Or maybe it is intended behavior. I am after all very new to 3D printing and a GitHub noob.

It did not do this on the stock firmware. Would a video help?

A video would help, its 16 point levelling and I dont know anything about going too far and then correcting itself.

@Fisheiyy Fisheiyy changed the title Add Ender 3 S1 Plus & Fix comments/crashing for S1 Add Ender 3 S1 Plus Sep 11, 2022
@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Sep 11, 2022

@KevinOConnor #5771 Now contains the fixes to the S1 Config and this PR only adds the S1 Plus Config now.

@antiLegion
Copy link

Just tested the latest config.
Homing then calibrating no longer causes a bang/crash.
Looks good! Great work y'all!

@Fisheiyy
Copy link
Contributor Author

@KevinOConnor Ready to merge afaik

@KevinOConnor KevinOConnor merged commit 7527e57 into Klipper3d:master Sep 16, 2022
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

eliasbakken pushed a commit to intelligent-agent/klipper that referenced this pull request Jan 31, 2023
Gi7mo pushed a commit to Gi7mo/klipper that referenced this pull request Feb 15, 2023
tntclaus pushed a commit to tntclaus/klipper that referenced this pull request May 29, 2023
revilo196 pushed a commit to revilo196/klipper that referenced this pull request Jun 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants