-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ender 3 S1 Plus #5705
Add Ender 3 S1 Plus #5705
Conversation
Thanks. The changes to the s1 config look fine to me. I'm not sure about the addition of the "s1 plus" config. Please separate out the addition of s1-plus to a separate PR. I'd like to understand how much it differs from the existing "s1" config. Also, please confirm that config has been tested on the actual hardware, and please confirm that printer has the same issue with variable f103/f401 control boards. -Kevin |
I'm willing to test if needed. I have an Ender 3 S1 Plus. I attempted to flash the firmware yesterday but got stuck in boot/could never connect klipper to fluidd. |
They are all under the S1 family so they all share the same general structure, which would include motherboard(s) and related variable MCU problems, the S1 Plus has a much larger print volume, I would argue its a change more worthy of its own config rather than the S1 Pro since that was just a maximum temperature change. |
Check your MCU and flash accordingly, if you are trying to flash F103 firmware on a F401 it wont work. |
Thanks. I have no strong preference for adding s1plus config. Please do separate it out to a separate PR though, and I need to see confirmation that it has been tested and is working on the actual hardware. -Kevin |
I have successfully installed this on my Ender 3 S1 Plus. It only does this the first time after homing the axii. It did not do this on the stock firmware. Would a video help? |
A video would help, its 16 point levelling and I dont know anything about going too far and then correcting itself. |
@KevinOConnor #5771 Now contains the fixes to the S1 Config and this PR only adds the S1 Plus Config now. |
Just tested the latest config. |
@KevinOConnor Ready to merge afaik |
Thanks. -Kevin |
Signed-off-by: Rob Casper <[email protected]>
Signed-off-by: Rob Casper <[email protected]>
Signed-off-by: Rob Casper <[email protected]>
Signed-off-by: Rob Casper <[email protected]>
Signed-off-by: Rob Casper [email protected]
Follow up PR to #5571