Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ender 3 S1 Config #5771

Merged
merged 10 commits into from
Sep 12, 2022
Merged

Fix Ender 3 S1 Config #5771

merged 10 commits into from
Sep 12, 2022

Conversation

Fisheiyy
Copy link
Contributor

@Fisheiyy Fisheiyy commented Sep 11, 2022

I fixed the max temperature for the hotend and bed for the S1 non-pro based off the official diagram on the Creality website, fixed some crashing issues reported in #5689, and added the F401 Motherboard Variant clarifications per #5709.

Signed-off-by: Rob Casper [email protected]

@Fisheiyy Fisheiyy mentioned this pull request Sep 11, 2022
@KevinOConnor
Copy link
Collaborator

Thanks, it looks fine, but I don't see a signed-off-by line.

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Sep 12, 2022
@Fisheiyy
Copy link
Contributor Author

Thanks, it looks fine, but I don't see a signed-off-by line.

-Kevin

My bad, adding that now

@KevinOConnor KevinOConnor merged commit ee5bdba into Klipper3d:master Sep 12, 2022
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@Fisheiyy Fisheiyy deleted the fix-s1-config branch September 12, 2022 02:19
@kpavey
Copy link

kpavey commented Oct 29, 2022

Will this work on the Ender 3 S1 Pro as is?

@Fisheiyy
Copy link
Contributor Author

Will this work on the Ender 3 S1 Pro as is?

Yes this config was already merged into main, so it is the default config you see in the config_examples folder, it will work just fine on the S1 but if you want to use the high temperature aspect of it you need to change the max temperature to 300.

@carlhaun
Copy link

Hello :

Prior to flashing my new Ender 3 S1 Pro will I still have to get the numbers off of the motherboard processor ? I have read that you had a couple of different .bin files for the new Ender 3 s1 Pro which depends upon the serial number of the processor...seems like there would be an OctoPrint command for this ...?

Thanks !

@Fisheiyy
Copy link
Contributor Author

Hello :

Prior to flashing my new Ender 3 S1 Pro will I still have to get the numbers off of the motherboard processor ? I have read that you had a couple of different .bin files for the new Ender 3 s1 Pro which depends upon the serial number of the processor...seems like there would be an OctoPrint command for this ...?

Thanks !

There is no way to find this out without looking at the actual mcu, there is no commands, yes you still need to find the mcu type you have and need to make the firmware for that version

@carlhaun
Copy link

Thanks Fisheiyy !

I think I-am-a-gonna wait a bit until I flash Klipper onto my new toy then....

Your prompt response is greatly appreciated -

@grantland
Copy link

The stepper values here cause my S1 to crash when doing the bed leveling mesh due to pos_y being out of bounds.

FWIW I've pulled just the stepper_* and the bed_mesh values from #5689 and it seems to be working for me now.

@Fisheiyy
Copy link
Contributor Author

The stepper values here cause my S1 to crash when doing the bed leveling mesh due to pos_y being out of bounds.

FWIW I've pulled just the stepper_* and the bed_mesh values from #5689 and it seems to be working for me now.

#5689 (comment)

eliasbakken pushed a commit to intelligent-agent/klipper that referenced this pull request Jan 31, 2023
Gi7mo pushed a commit to Gi7mo/klipper that referenced this pull request Feb 15, 2023
tntclaus pushed a commit to tntclaus/klipper that referenced this pull request May 29, 2023
revilo196 pushed a commit to revilo196/klipper that referenced this pull request Jun 24, 2023
rogerlz referenced this pull request in DangerKlippers/danger-klipper Dec 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants