Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] remove deprecated configuration slated for removal in 2.x #303

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Mar 1, 2021

What this PR does / why we need it:

Clears out previously-deprecated template code scheduled for removal in 2.x. See individual commits/issues for details.

Which issue this PR fixes

Closes #286, #287, #288, and #289

Checklist

  • Title of the PR and commit headers start with chart name (e.g. [kong])

Travis Raines added 4 commits March 1, 2021 15:24
Removes the following deprecated Portal auth settings from values.yaml:
- enterprise.portal.session_conf_secret
- enterprise.portal.portal_auth

These are now normally set per-workspace via Kong Manager, and are
stored in Kong's database. The old environment variable settings are
still available, and are used as defaults when the workspace settings
are not explicitly set. They can still be set via the environment, by
setting portal_session_conf and portal_auth under env in values.yaml.

Fix #286
Removes the runMigrations setting from values.yaml. Migrations are now
controlled individually:

- migrations.init (runs "kong migrations bootstrap" on install)
- migrations.preUpgrade (runs "kong migrations up" during upgrades)
- migrations.postUpgrade (runs "kong migrations finish" during upgrades)

Fix #288
The admin API configuration could only set up a single port, either HTTP
or HTTPS. #72 added support for
dual-stack admin API configuraton using the same templates as other Kong
services.

Fix #287
Removes support for proxy ingress configuration with multiple hostnames.
#251 added a shared Ingress and
Service template for all Kong services, which only supports a single
hostname.

Fix #289
@rainest rainest requested a review from a team as a code owner March 1, 2021 23:35
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and I have no blockers, but someone with more historical context might want to review this as well.

@rainest rainest merged commit 4f7510b into stage/kong-2.x Mar 3, 2021
@rainest rainest deleted the chore/deprecations branch March 3, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants