[kong] merge staged 2.x changes into next #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 4, 2021 09:10
Upgrade CI actions for use with Helm 3. The chart-testing action changed significantly in its 2.0.0 release and the workflow is almost completely new. The revision is mostly their current example: https://github.com/helm/chart-testing-action/tree/v2.0.1#upgrading-from-v1xx These changes no longer use the config files and exclude the original timeout override. It doesn't look like we should need that since the current default is longer than the old override (300s vs 200s).
Revert to an older version of Helm 3. 3.2.4 is the last version that does not raise a linter failure on the older APIs we use with the controller: Kong/kubernetes-ingress-controller#801
If admission webhook certificates are already present on the cluster, use them instead of generating a new certificate. Fix #253
On review of the history behind this, we don't need this checksum if we don't expect the certificate to change. We added it as a workaround for failures caused by the certificate rotating on update: helm/charts#20050
Removes the following deprecated Portal auth settings from values.yaml: - enterprise.portal.session_conf_secret - enterprise.portal.portal_auth These are now normally set per-workspace via Kong Manager, and are stored in Kong's database. The old environment variable settings are still available, and are used as defaults when the workspace settings are not explicitly set. They can still be set via the environment, by setting portal_session_conf and portal_auth under env in values.yaml. Fix #286
Removes the runMigrations setting from values.yaml. Migrations are now controlled individually: - migrations.init (runs "kong migrations bootstrap" on install) - migrations.preUpgrade (runs "kong migrations up" during upgrades) - migrations.postUpgrade (runs "kong migrations finish" during upgrades) Fix #288
shaneutt
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Merges Helm 3-based CI and 2.x changes from
stage/2.xintonextWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
New branch since I messed up next merges in
stage/2.xand created duplicate commits. This branch cherry-picks the actual new commits.Previous PRs for non-CI features:
#256 (preserving generated admission webhook certificate across upgrades)
#303 (removing deprecated features)
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmain[kong])