Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove built files from source control and update bootstrap steps #2165

Merged
merged 10 commits into from
May 14, 2020
Merged

Remove built files from source control and update bootstrap steps #2165

merged 10 commits into from
May 14, 2020

Conversation

develohpanda
Copy link
Contributor

@develohpanda develohpanda commented May 13, 2020 •
edited
Loading

Remove dist from insomnia-components and openapi-2-kong from source control, and update the bootstrap steps for each to build during bootstrap.

After a dry-run, with .npmignore:
image

image

@develohpanda develohpanda requested a review from gschier May 13, 2020 03:55
@develohpanda develohpanda self-assigned this May 13, 2020
@netlify
Copy link

netlify bot commented May 13, 2020 •
edited
Loading

Deploy preview for insomnia-storybook ready!

Built with commit d3379fe

https://deploy-preview-2165--insomnia-storybook.netlify.app

gschier
gschier suggested changes May 14, 2020
View reviewed changes
Copy link
Contributor

@gschier gschier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about publishing to NPM

packages/insomnia-components/.gitignore Show resolved Hide resolved
@develohpanda develohpanda requested a review from gschier May 14, 2020 02:22
@develohpanda develohpanda merged commit 011fa00 into develop May 14, 2020
@develohpanda develohpanda deleted the feature/remove-dist branch May 14, 2020 20:57
@develohpanda develohpanda mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschier gschier gschier approved these changes

Assignees

@develohpanda develohpanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@develohpanda @gschier