Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built files from source control and update bootstrap steps #2165

Merged
merged 10 commits into from
May 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/insomnia-components/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.cache
storybook-static
assets/svgr
dist
develohpanda marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 7 additions & 0 deletions packages/insomnia-components/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Ignore everything by default
# NOTE: NPM publish will never ignore package.json, package-lock.json, README, LICENSE, CHANGELOG
# https://npm.github.io/publishing-pkgs-docs/publishing/the-npmignore-file.html
*

# Don't ignore dist folder
!dist/*
67 changes: 0 additions & 67 deletions packages/insomnia-components/dist/index.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/insomnia-components/dist/index.js.map

This file was deleted.

9 changes: 5 additions & 4 deletions packages/insomnia-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,17 @@
"license": "MIT",
"main": "dist/index.js",
"scripts": {
"test": "flow check",
"typecheck": "flow check",
"build": "webpack --config webpack.config.js --display errors-only",
"build-storybook": "build-storybook --quiet",
"storybook": "start-storybook --port 3223",
"bootstrap": "rimraf node_modules/fsevents && npm run convert-svg",
"convert-svg": "rimraf assets/svgr && svgr --out-dir assets/svgr assets && rimraf assets/svgr/index.js"
"bootstrap": "rimraf node_modules/fsevents && npm run convert-svg && npm run build",
"convert-svg": "rimraf assets/svgr && svgr --out-dir assets/svgr assets && rimraf assets/svgr/index.js",
"prepublish": "npm run convert-svg && npm run build"
},
"husky": {
"hooks": {
"pre-commit": "pretty-quick --staged && npm run build"
"pre-commit": "pretty-quick --staged && npm run typecheck"
}
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/openapi-2-kong/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist
7 changes: 7 additions & 0 deletions packages/openapi-2-kong/.npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Ignore everything by default
# NOTE: NPM publish will never ignore package.json, package-lock.json, README, LICENSE, CHANGELOG
# https://npm.github.io/publishing-pkgs-docs/publishing/the-npmignore-file.html
*

# Don't ignore dist folder
!dist/*
2 changes: 0 additions & 2 deletions packages/openapi-2-kong/dist/index.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/openapi-2-kong/dist/index.js.map

This file was deleted.

9 changes: 6 additions & 3 deletions packages/openapi-2-kong/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@
"version": "2.2.4",
"main": "dist/index.js",
"scripts": {
"test": "flow check && jest",
"build": "webpack --config webpack.config.js --display errors-only"
"typecheck": "flow check",
"test": "npm run typecheck && jest",
"build": "webpack --config webpack.config.js --display errors-only",
"bootstrap": "npm run build",
"prepublish": "npm run build"
},
"husky": {
"hooks": {
"pre-commit": "npm run build"
"pre-commit": "npm run typecheck"
}
},
"jest": {
Expand Down