Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.12.3 #5257

Closed
16 of 27 tasks
tao12345666333 opened this issue Nov 30, 2023 · 5 comments
Closed
16 of 27 tasks

Release v2.12.3 #5257

tao12345666333 opened this issue Nov 30, 2023 · 5 comments

Comments

@tao12345666333
Copy link
Member

tao12345666333 commented Nov 30, 2023

Release Type

patch

For major/minor releases Create release/<MAJOR>.<MINOR>.x Branch

  • Create the release/<MAJOR>.<MINOR>.x branch at the place where you want to branch of off main

For all releases Create prepare-release/x.y.z Branch

  • Ensure that you have up to date copy of main: git checkout main; git pull or a targeted release branch e.g. release/2.7.x: git checkout release/2.7.x; git pull
  • Create the prepare-release branch for the version (e.g. prepare-release/2.7.1): git branch -m prepare-release/2.7.1
  • Review carefully CHANGELOG.md. Manually reorder entries for relevance, common topic, adjust description, etc. - make it clear and easy to follow for users. Optionally headline notable changes (emojis are allowed). Double-check that dates are correct, that link anchors point to the correct header, and that you've included a link to the GitHub compare link at the end. If there were any RC releases before this version, fold their changes into the final release entry.
  • Resolve all licensing issues that FOSSA has detected. Go to Issues tab in FOSSA's KIC project and resolve every issue, inspecting if it's a false positive or not. ignored.go script should be useful to look for issues that have been already resolved and reappeared due to version changes.
  • Update ignored.json following instructions in README.
  • Retrieve the latest license report from FOSSA and save it to LICENSES (go to Reports tab in FOSSA's KIC project, select 'plain text' format, tick 'direct dependencies' and download it).
  • Ensure base manifest versions use the new version (config/image/enterprise/kustomization.yaml and config/image/oss/kustomization.yaml) and update manifest files: make manifests
  • Push the branch up to the remote: git push --set-upstream origin prepare-release/x.y.z

For all releases Create a Release Pull Request

  • Check the latest E2E nightly test run to confirm that E2E tests are succeeding. If you are backporting features into a non-main branch, run a targeted E2E job against that branch or use ci/run-e2e label on the PR preparing the release.
  • Open a PR from your branch to main. Set a backport release/X.Y.Z label.
  • If this is a patch release, ensure that the release branch (e.g. release/2.9.x) compared against the latest patch for this minor release (e.g. v2.9.0) includes the expected changes that the release should include (e.g. by checking https://github.com/kong/kubernetes-ingress-controller/compare/v2.9.0..release/2.9.x).
  • Once the PR is merged (the prepare-release/x.y.z branch will get automatically removed), approve and merge the automatic backport PR and initiate a release job on the main branch for major or minor release, for patch use the release branch. Your tag must use vX.Y.Z format. Set latest to true if this is be the latest release. That should be the case if a new major.minor release is done or a patch release is done on the latest minor version.
  • CI will validate the requested version, build and push an image, and run tests against the image before finally creating a tag and publishing a release. If tests fail, CI will push the image but not the tag or release. Investigate the failure, correct it as needed, and start a new release job.
  • The release workflow (.github/workflows/release.yaml) will update the latest branch - if the released version was set to be latest - to the just released tag.

For major/minor releases only Update Release documents

  • Trigger release_docs workflow. Note that you will need to update the new version's navigation manifest (e.g. for 2.7 to use the new files (CRDs and CLI arguments references) after.
  • Ensure a draft PR is created in docs.konghq.com repository.
  • If you are adding a new CRD, add a new description file under app/_includes/md/kic/crd-ref/. This is a brief description injected into the CRD reference page.
  • Update articles in the new version as needed.
  • Update reference/version-compatibility.md to include the new versions (make sure you capture any new Kubernetes/Istio versions that have been tested)
  • Copy app/_data/docs_nav_kic_OLDVERSION.yml to app/_data/docs_nav_kic_NEWVERSION.yml and update the release field to NEWVERSION. Add entries for any new articles.
  • Make sure that app/_data/docs_nav_kic_NEWVERSION.yml links to the latest generated custom-resources-X.X.X.md.
  • Add a section to app/_data/kong_versions.yml for your version.
  • Add entries in support policy documents: app/_includes/md/support-policy.md and app/_src/kubernetes-ingress-controller/support-policy.md.
  • Mark the PR ready for review.
  • Inform and ping the @Kong/team-k8s via slack of impending release with a link to the release PR.
  • Ensure that KGO works with the released version of KIC. Update and release it if needed.

Conformance tests report

Trigger for released version CI workflow Generate Kubernetes Gateway API conformance tests report, verify artifact and submit it to https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports. It's still in experimental phase. Update the KIC version in the README's Gateway API conformance badge.

Release Troubleshooting

The Release Troubleshooting guide covers strategies for dealing with a release that has failed.

@tao12345666333 tao12345666333 changed the title Release v2.12.2 Release v2.12.3 Nov 30, 2023
@randmonkey randmonkey added this to the KIC v2.12.x milestone Nov 30, 2023
@tao12345666333
Copy link
Member Author

wait: #5346

@tao12345666333
Copy link
Member Author

When I tried to run the e2e test, I encountered the same situation as #5313

@tao12345666333
Copy link
Member Author

Let's backport #5327 to v2.12.x

@tao12345666333
Copy link
Member Author

tao12345666333 commented Dec 19, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants