-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport(v2.12.x): fix(tests): skip upgrade tests if not upgrading between two consecuti… #5365
Backport(v2.12.x): fix(tests): skip upgrade tests if not upgrading between two consecuti… #5365
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.x #5365 +/- ##
================================================
- Coverage 68.0% 68.0% -0.1%
================================================
Files 165 165
Lines 19344 19352 +8
================================================
+ Hits 13159 13163 +4
- Misses 5397 5401 +4
Partials 788 788 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit wrt the PR: I'd suggest to include the target version (or branch) in the PR title so that it's obvious when looking at the PR list what this PR tried to achieve.
Ideally we'd also add this issue into the respective Milestone but that's minor thing.
E2E (targeted) tests with KIND-based and GKE-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7261609627 |
…ve Kong versions (#5327)
(cherry picked from commit 614c6c0)
What this PR does / why we need it:
#5257 (comment)
Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR