Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print concrete error from fillPlugin in logs #5346

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

Print the concrete error returned from fillPlugin function in logs.

Which issue this PR fixes:

part of #5341
Special notes for your reviewer:

REVIEW: how to write changelog for this?

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner December 15, 2023 06:42
@randmonkey randmonkey self-assigned this Dec 15, 2023
@randmonkey randmonkey added this to the KIC v2.12.x milestone Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b929f67) 68.0% compared to head (925b7e0) 68.0%.
Report is 2 commits behind head on release/2.12.x.

Files Patch % Lines
internal/manager/run.go 44.4% 4 Missing and 1 partial ⚠️
internal/dataplane/deckgen/generate.go 66.6% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/2.12.x   #5346     +/-   ##
================================================
- Coverage            68.0%   68.0%   -0.1%     
================================================
  Files                 165     165             
  Lines               19344   19352      +8     
================================================
+ Hits                13159   13164      +5     
- Misses               5397    5401      +4     
+ Partials              788     787      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tao12345666333
Copy link
Member

#5347 will fix the CI failure

@tao12345666333 tao12345666333 mentioned this pull request Dec 15, 2023
27 tasks
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits: we could use WithError to log the error as a log field.

internal/dataplane/deckgen/generate.go Outdated Show resolved Hide resolved
internal/dataplane/deckgen/generate.go Outdated Show resolved Hide resolved
internal/dataplane/deckgen/generate.go Outdated Show resolved Hide resolved
Co-authored-by: Grzegorz Burzyński <[email protected]>
@tao12345666333 tao12345666333 merged commit 622c990 into release/2.12.x Dec 15, 2023
32 checks passed
@tao12345666333 tao12345666333 deleted the backport/log-fillPlugin-error-2.12 branch December 15, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants