-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print concrete error from fillPlugin in logs #5346
fix: print concrete error from fillPlugin in logs #5346
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.x #5346 +/- ##
================================================
- Coverage 68.0% 68.0% -0.1%
================================================
Files 165 165
Lines 19344 19352 +8
================================================
+ Hits 13159 13164 +5
- Misses 5397 5401 +4
+ Partials 788 787 -1 ☔ View full report in Codecov by Sentry. |
#5347 will fix the CI failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits: we could use WithError
to log the error as a log field.
Co-authored-by: Grzegorz Burzyński <[email protected]>
What this PR does / why we need it:
Print the concrete error returned from
fillPlugin
function in logs.Which issue this PR fixes:
part of #5341
Special notes for your reviewer:
REVIEW: how to write changelog for this?
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR