Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Plugins (GetSchema), Workspaces (Exists,Create), Tags (Exists) me… #1321

Merged
merged 19 commits into from
Jun 17, 2021
Merged

Use Plugins (GetSchema), Workspaces (Exists,Create), Tags (Exists) me… #1321

merged 19 commits into from
Jun 17, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 14, 2021

Use Go-kong client's features
Fixes #1284

@mmorel-35 mmorel-35 requested a review from a team as a code owner May 14, 2021 11:15
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1321 (9c0efbc) into next (8049db4) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1321      +/-   ##
==========================================
+ Coverage   55.68%   55.76%   +0.08%     
==========================================
  Files          43       43              
  Lines        3694     3683      -11     
==========================================
- Hits         2057     2054       -3     
+ Misses       1489     1480       -9     
- Partials      148      149       +1     
Impacted Files Coverage Δ
cli/ingress-controller/main.go 0.24% <0.00%> (+<0.01%) ⬆️
cli/ingress-controller/util.go 47.82% <0.00%> (+7.08%) ⬆️
pkg/util/plugin_schema_helper.go 0.00% <0.00%> (ø)
pkg/parser/parser.go 82.83% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8049db4...9c0efbc. Read the comment docs.

@shaneutt shaneutt self-requested a review May 25, 2021 17:34
@shaneutt shaneutt self-assigned this May 25, 2021
@shaneutt shaneutt added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. bug Something isn't working labels May 25, 2021
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmorel-35 😃

Since we're already this far, would you mind please adding the update to go-kong which this fix provides for?

@mmorel-35
Copy link
Contributor Author

@shaneutt, I'm not sure to understand. What do you expect me to do ?

@shaneutt
Copy link
Contributor

@shaneutt, I'm not sure to understand. What do you expect me to do ?

What I was thinking was since this fixes the problem for #1284 and makes it possible now to upgrade to go-kong v0.18.0, would you be comfortable with just adding that update as a part of this PR?

e.g.

$ go get github.com/kong/[email protected]

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented May 25, 2021

I'm not sure it's the right thing to do, as go-kong is in a greater version now. See:

github.com/kong/go-kong v0.19.0

@shaneutt
Copy link
Contributor

Ok in that case if you're not comfortable then no worries. Let's bump for the most recent next...

@shaneutt shaneutt self-requested a review May 27, 2021 13:47
@shaneutt shaneutt merged commit 3600658 into Kong:next Jun 17, 2021
@mmorel-35 mmorel-35 deleted the chore/go-kong-0.18.0 branch June 17, 2021 14:21
@shaneutt shaneutt mentioned this pull request Jul 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. bug Something isn't working pending author feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants