-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Plugins (GetSchema), Workspaces (Exists,Create), Tags (Exists) me… #1321
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1321 +/- ##
==========================================
+ Coverage 55.68% 55.76% +0.08%
==========================================
Files 43 43
Lines 3694 3683 -11
==========================================
- Hits 2057 2054 -3
+ Misses 1489 1480 -9
- Partials 148 149 +1
Continue to review full report at Codecov.
|
This reverts commit f3e95e5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmorel-35 😃
Since we're already this far, would you mind please adding the update to go-kong
which this fix provides for?
@shaneutt, I'm not sure to understand. What do you expect me to do ? |
What I was thinking was since this fixes the problem for #1284 and makes it possible now to upgrade to e.g.
|
I'm not sure it's the right thing to do, as go-kong is in a greater version now. See: kubernetes-ingress-controller/go.mod Line 20 in 6caaaea
|
Ok in that case if you're not comfortable then no worries. Let's bump for the most recent |
Use Go-kong client's features
Fixes #1284