Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enablement env vars bools #1507

Closed
wants to merge 1 commit into from
Closed

enablement env vars bools #1507

wants to merge 1 commit into from

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Jul 7, 2021

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

This patch will automatically convert boolean values into
util.EnablementStatus values for any corresponding ENV var.
This makes it convenient to set "true" or "false" for enabling
controllers if the caller wishes to do so.
@shaneutt shaneutt requested a review from a team as a code owner July 7, 2021 19:16
@shaneutt shaneutt temporarily deployed to Configure ci July 7, 2021 19:16 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 7, 2021 19:16 Inactive
@shaneutt shaneutt changed the base branch from main to next July 7, 2021 19:17
@shaneutt shaneutt closed this Jul 7, 2021
@shaneutt shaneutt deleted the enablement-env-vars-bools branch July 7, 2021 19:17
@shaneutt shaneutt temporarily deployed to Configure ci July 7, 2021 19:18 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 7, 2021 19:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant