Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kic 2.0) add profiling #1417

Merged
merged 5 commits into from
Jun 11, 2021
Merged

feat(kic 2.0) add profiling #1417

merged 5 commits into from
Jun 11, 2021

Conversation

tharun208
Copy link
Contributor

@tharun208 tharun208 commented Jun 11, 2021

Signed-off-by: Tharun [email protected]

What this PR does / why we need it: This PR introduces profiling for kic 2.x

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1298

Special notes for your reviewer:
Created a separate server as when #1278 is implemented it will be easy to add to this change.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tharun208 tharun208 requested a review from a team as a code owner June 11, 2021 06:56
@tharun208
Copy link
Contributor Author

raised a new pr as #1408 messed up. either we can go with this one or #1416

Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring requests attached - the implementation and the test look neat otherwise!

CHANGELOG.md Outdated Show resolved Hide resolved
railgun/manager/run.go Outdated Show resolved Hide resolved
railgun/pkg/config/config.go Outdated Show resolved Hide resolved
railgun/pkg/config/config.go Outdated Show resolved Hide resolved
railgun/internal/diagnostics/server.go Outdated Show resolved Hide resolved
railgun/internal/diagnostics/server.go Outdated Show resolved Hide resolved
railgun/internal/mgrutils/profiling.go Outdated Show resolved Hide resolved
railgun/internal/diagnostics/server.go Outdated Show resolved Hide resolved
railgun/internal/diagnostics/server.go Outdated Show resolved Hide resolved
railgun/internal/diagnostics/server.go Outdated Show resolved Hide resolved
@mflendrich mflendrich requested a review from rainest June 11, 2021 12:13
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1417 (6e7d531) into next (897d8a2) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1417      +/-   ##
==========================================
- Coverage   55.29%   55.08%   -0.22%     
==========================================
  Files          42       42              
  Lines        3646     3660      +14     
==========================================
  Hits         2016     2016              
- Misses       1479     1493      +14     
  Partials      151      151              
Impacted Files Coverage Δ
railgun/cmd/rootcmd/run.go 0.00% <0.00%> (ø)
railgun/cmd/rootcmd/servers.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897d8a2...6e7d531. Read the comment docs.

Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rainest rainest merged commit 54c8000 into Kong:next Jun 11, 2021
@rainest
Copy link
Contributor

rainest commented Jun 11, 2021

@tharun208 Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.

@tharun208 tharun208 deleted the feat/profiling_for_kic_2.0 branch June 11, 2021 16:59
@shaneutt shaneutt mentioned this pull request Jul 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants