-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kic 2.0) add profiling #1417
Conversation
Signed-off-by: Tharun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some refactoring requests attached - the implementation and the test look neat otherwise!
Codecov Report
@@ Coverage Diff @@
## next #1417 +/- ##
==========================================
- Coverage 55.29% 55.08% -0.22%
==========================================
Files 42 42
Lines 3646 3660 +14
==========================================
Hits 2016 2016
- Misses 1479 1493 +14
Partials 151 151
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@tharun208 Thank you for your contribution. Please fill out the following form to claim your contributor swag: |
Signed-off-by: Tharun [email protected]
What this PR does / why we need it: This PR introduces profiling for kic 2.x
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #1298Special notes for your reviewer:
Created a separate server as when #1278 is implemented it will be easy to add to this change.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR