-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework 2.x RBAC generators #1457
Conversation
Licenses differ between commit 66977e7fb964aaa0d78b7ea98368afae7872701c and base:
|
Codecov Report
@@ Coverage Diff @@
## next #1457 +/- ##
=======================================
Coverage 55.79% 55.79%
=======================================
Files 44 44
Lines 3733 3733
=======================================
Hits 2083 2083
Misses 1501 1501
Partials 149 149 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Shane Utt <[email protected]>
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #1215Special notes for your reviewer:
railgun/hack/generators/controllers/networking/main.go
) as they aren't controllers, but there isn't an obvious better place to place it already. This at least provides a single location to configure both types of things that generate RBAC permissions.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR