-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expression router) move setting protocols back to kongstate override for expression based routes #4422
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
=======================================
+ Coverage 67.5% 67.7% +0.2%
=======================================
Files 159 159
Lines 18803 18772 -31
=======================================
+ Hits 12699 12724 +25
+ Misses 5340 5284 -56
Partials 764 764
☔ View full report in Codecov by Sentry. |
8a7873b
to
4b4513a
Compare
Allowed myself to rebase onto main and regenerate golden files (needed after #4426). |
4b4513a
to
702376f
Compare
d4fcdb8
to
4a1154a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
What this PR does / why we need it:
As suggested by gateway team, it is better to configure the protocols of Kong routes in
protocols
field than filling them directly into the expression. This PR moves the filling protocol back to thekongstate
override phase of generated Kong routes, as with traditional router.Which issue this PR fixes:
fixes #4313
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR