tests: add parser golden tests covering expression routes #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
expression-routes-golden-tests
branch
2 times, most recently
from
1963023
to
79c5f05
Compare
czeslavo
force-pushed
the
expression-routes-golden-tests
branch
from
79c5f05
to
a2dcd40
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
=======================================
- Coverage 67.2% 67.2% -0.1%
=======================================
Files 159 159
Lines 18749 18749
=======================================
- Hits 12609 12605 -4
- Misses 5379 5384 +5
+ Partials 761 760 -1 ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Jul 28, 2023
internal/dataplane/parser/testdata/golden/httproute-example/expression-routes-on_golden.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds settings to cover
ExpressionRoutes: trueto the existing Ingress and GRPCRoute tests, adds a newHTTPRoutetest.