Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compilation warnings about malformed LC_DYSYMTAB #5829

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 8, 2024

What this PR does / why we need it:

This PR aims to fix compilation warnings which clutter the compilation or test console output on Mac:

make test.unit.pretty
GOTESTSUM_FORMAT=pkgname \
                /Users/[email protected]/code_/kubernetes-ingress-controller/bin/installs/gotestsum/1.11.0/bin/gotestsum -- \
                -race  \
                -tags envtest \
                -covermode=atomic \
                -coverpkg=./pkg/...,./internal/... \
                -coverprofile=coverage.unit.out \
                ./internal/... \
                ./pkg/...
# github.com/kong/kubernetes-ingress-controller/v3/internal/admission/validation/consumers/credentials.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-3731571908/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
# github.com/kong/kubernetes-ingress-controller/v3/internal/clients.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-1021094792/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
# github.com/kong/kubernetes-ingress-controller/v3/internal/admission/validation/ingress.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-760119589/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
# github.com/kong/kubernetes-ingress-controller/v3/internal/admission/validation/gateway.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-1133689882/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
# github.com/kong/kubernetes-ingress-controller/v3/internal/adminapi.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-472019086/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
# github.com/kong/kubernetes-ingress-controller/v3/internal/admission.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-1992632925/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
∅  internal/cmd (19ms) (coverage: 0.0% of statements)
∅  internal/admission/validation (22ms) (coverage: 0.0% of statements)
# github.com/kong/kubernetes-ingress-controller/v3/internal/cmd/rootcmd.test
ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-1637700810/000023.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626
∅  internal/controllers

related: golang/go#61229 (comment)

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Apr 8, 2024
@pmalek pmalek self-assigned this Apr 8, 2024
@pmalek pmalek requested a review from a team as a code owner April 8, 2024 14:06
@pmalek pmalek enabled auto-merge (squash) April 8, 2024 14:06
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed it works

@pmalek pmalek merged commit 8b2a017 into main Apr 8, 2024
56 checks passed
@pmalek pmalek deleted the fix-malformed-lc-dysymtab-on-mac branch April 8, 2024 14:29
czeslavo added a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants