Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(conformance): use router flavor instead of separate flag for enabling expressions router #5860

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 11, 2024

What this PR does / why we need it:

Use the same env as elsewhere for router flavor ( TEST_KONG_ROUTER_FLAVOR ) instead of a dedicated one which indicated whether those are enabled or not ( KONG_TEST_EXPRESSION_ROUTES ).

Also add ldflags to fix compilation warnings on mac similarly as it was done in #5829.

@pmalek pmalek self-assigned this Apr 11, 2024
@pmalek pmalek requested a review from a team as a code owner April 11, 2024 12:25
@pmalek pmalek enabled auto-merge (squash) April 11, 2024 12:25
@pmalek pmalek force-pushed the gwapi-conformance-use-router-flavor-env branch from f6c1300 to 76a66bf Compare April 11, 2024 12:56
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.0%. Comparing base (5267051) to head (76a66bf).
Report is 1 commits behind head on main.

❗ Current head 76a66bf differs from pull request most recent head 2d1f17c. Consider uploading reports for the commit 2d1f17c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5860     +/-   ##
=======================================
- Coverage   72.0%   72.0%   -0.1%     
=======================================
  Files        178     178             
  Lines      18210   18210             
=======================================
- Hits       13129   13116     -13     
- Misses      4104    4114     +10     
- Partials     977     980      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/conformance/gateway_conformance_test.go Outdated Show resolved Hide resolved
test/conformance/suite_test.go Outdated Show resolved Hide resolved
@pmalek pmalek requested a review from czeslavo April 11, 2024 13:48
@pmalek pmalek merged commit 26a36a4 into main Apr 11, 2024
36 checks passed
@pmalek pmalek deleted the gwapi-conformance-use-router-flavor-env branch April 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants