ma/#1028-update-default-config-for-iter-linkstats-output-4ci Updated …

[mr-asif-nor]

Fixed #1028
…the linkstats module config to disable it effectively for writing linkstats.txt.gz file

---

This change is 

[JustinPihony]

It seems that it would be easier to set the default in beam-template and let that trickle down to all, unless I missed something

[mr-asif-nor]

Its a matsim module config. Perhaps this is the right way to do this. I had a discussion on this with @wrashid He can better confirm.

[colinsheppard]

I would prefer that we move away from using parameters in the MATSim configurations. If we need the MATSim parameter to be set, then we mutate them after reading the beam config options. For an example of this see BeamHelper line 388:

matsimConfig.controler().setWritePlansInterval(beamConfig.beam.outputs.writePlansInterval)

If this is not possible, i.e. if matsim doesn't let you mutate, then let's have a discussion and try to find a better way.

So this means that most of the changes you made in this PR would need to be reverted.

Reviewed 10 of 10 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wrashid)

[colinsheppard]

@mr-asif-nor please see what we're doing in this PR for an example of how we want this:

#1061

You could wait for that PR to be merged and then follow the example there.

[mr-asif-nor]

Ok

[mr-asif-nor]

@colinsheppard
I have resolved the conflicts and I have put the following config in the common/matsim.conf file
linkStats {
writeLinkStatsInterval = 0
averageLinkStatsOverIterations = 0
}

[colinsheppard]

test!

[colinsheppard]

Reviewed 1 of 10 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wrashid)

[colinsheppard]

test!