extract matsim properties from beam.conf to matsim.conf #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
JustinPihony
approved these changes
Dec 24, 2018
|
We still need to create params for all of the typical and useful things we do in BEAM and then set them in the config object during runtime. E.g. firstIter / lastIter |
|
@rajnikantsh Please look closely at the changes I made and then apply the same changes to all of the sf-light config files:
Please test and make sure that the model runs for all of the updated conf files. Finally, please confirm for all of these parameters that the values are successfully communicated through to the BeamConfig class at runtime and not just taking on default values. |
|
I've renamed and repositioning many of the params in sf-light-1k. You can copy these changes to all of the sf-light files but just duplicating from sf-light-1k and replacing 1k withe the appropriate value (and be sure to change beam.agentsim.numAgents to the appropriate value as well). |
colinsheppard
pushed a commit
that referenced
this pull request
Jan 7, 2019
* add misc summary stats (#1085) * add misc summary stats * add null check and change return syntax * refactoring * bug fix: wrong field used * refactor: reuse code * add totalHoursOfVehicleTrafficDelay in summary stats. * add summary stats for averagePTWaitingTime * add bus crowding in summary stats * reset bus crowding * add averageTripExpenditure in summary stats * fixed cost aggregation * fixed PTCrowding (bus) * renamed to totalNetCost * fixed warnings * reset ptWaiting against personId * fixed average and update labels * hoursTraveled should be renamed to travelDurationInSec, as this is not in hours * remove / 3600 for busCrowding * fixed hard coding of modes * fixed hard coding of modes * rename _person * fixed warnings and format * create summary stats for average vehicle delay for motorized leg. (#1095) * fixed numOfTimesBusTaken in busCrowding * changed buses list to set * fixed averageVehicleDelay * fixed delay stat variable name * fixed delay stats calculation * fix n/0 issue * fix totalVehicles for averageDelays * fix failing run for sf-light scenario (#1097) * fix sf-light run * fix comment * can give too much logging when vehicles misconfigured so make exponential * Cs/#1099 rhm batch and repos (#1104) * initial attempt to enable co-execution of these processes, still buggy * debugging * found bug related to new requests coming in while buffered requests being processed, more robust now * fixing regression * another glitch solved * finally getting simultaneous timeouts working * fmt * allow pass when not in batch mode * ignore failing test * debug statements mistakently lefts as info * summary stats modification (#1110) * Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf add averageVehicleTravelPerPassengerTrip and averageTravelExpenditure for each activity * changed variable name * Cs/#1082 refine analysis (#1109) * turns into case objects, change delay metric bins * change delay metric plot (#1083) * change plot for delay metric * Scala fmt * resolved average delay graph issue * more descriptive titles * space * debugging non-deterministic stuck issue * fmt * repairing the fallback BeamPath used for transit trips that can't be … (#1106) * repairing the fallback BeamPath used for transit trips that can't be routed to avoid exceptions later on (cherry picked from commit 2cd4bdc) * scalafmt * ignore flaky test. * Cs/#1100 Refactor (#1113) * decompose some code from RHM into new class to clear things a bit * fmt * clean * extract matsim properties from beam.conf to matsim.conf (#1061) * extract matsim properties from beam.conf to matsim.conf * fmt * set param in beam config and referred in matsim config * renaming and moving * better default for iters * remaining changes in extracting matsim config * Merge remote-tracking branch 'remotes/origin/master' into rajnikantsh/#1008-extract-matsim-conf-4ci # Conflicts: # test/input/sf-light/sf-light-1k.conf reset agent number in sf-light-2.5k * renaming and reogranizing params * renaming and repositioning of sf-light * fmt * extract matsim from base conf * Merge branch 'master' into rajnikantsh/1115-extract-baseconf-4ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1008
This change is