Fdariasm/#415 generalized csv reader 4ci #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
colinsheppard
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sfwatergit)
fdariasm
added a commit
that referenced
this pull request
Sep 2, 2018
fdariasm
added a commit
that referenced
this pull request
Sep 12, 2018
* Change to BeamVehicleType for #433 Remove case object BeamVehicleType for different categories, RideHail, CarVehicle, etc. * Reading CSV files for vehicle data #433 * #443 - refactor vehicle types - project building after refactoring, data added * #433 - fix to vehicles input reading * #433 - adjusting input data * #433 - adjusting vehicle type input data for default transit types * #433 - comments and TODO cleanup * Merge master into refactor vehicles branch * #433 - ignore test with missing vehicle input data * Ignore tests missing new vehicles input data * #433 - remove duplicated line in conf * #433 - ignore failing test * #433 - ignoring failing tests
colinsheppard
pushed a commit
that referenced
this pull request
Sep 18, 2018
* Change to BeamVehicleType for #433 Remove case object BeamVehicleType for different categories, RideHail, CarVehicle, etc. * Reading CSV files for vehicle data #433 * #443 - refactor vehicle types - project building after refactoring, data added * #433 - fix to vehicles input reading * #433 - adjusting input data * #433 - adjusting input data * Dummy commit * #433 - adjusting vehicle type input data for default transit types * #433 - comments and TODO cleanup * Merge master into refactor vehicles branch * #433 - ignore test with missing vehicle input data * Ignore tests missing new vehicles input data * #433 - remove duplicated line in conf * #433 - ignore failing test * #433 - ignoring failing tests * #502 - generating CSV files for vehicles data * #502 - generating vehicles.xml as they are required by BEAM * #502 - fix folder creation in default parking stall to csv generation * #502 - code cleanup * #502 - modify conversion tool to generate vehicle data for beam scenarios * Update to vehicles input data - #502 * #502 - update to sf-light vehicles input data * #502 - refactor to missing class that used matsim vehicles to use beamVehicles * #502 - WarmStartRoutingSpec passing * fix average travel time graphs and created a new graph for others category (#586) * fmt * ignore test to allow full spec execution * ignore more to get all tests to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after comments in #384, items:
This change is