Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings #297

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Refactor settings #297

merged 4 commits into from
Oct 22, 2019

Conversation

dgdekoning
Copy link
Contributor

Shuffle settings-related code into the settings classes to keep logic in one place.

Add separate testing for the settings classes.

This is half of the #249 pull-request. Only refactoring the settings code.

@dgdekoning dgdekoning added feature Issues/PRs related to a new feature tests labels Oct 21, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 44.941% when pulling 0fd5612 on dgdekoning:refactor-settings into 9b1d34c on LCA-ActivityBrowser:master.

@dgdekoning dgdekoning merged commit a12c18d into LCA-ActivityBrowser:master Oct 22, 2019
@dgdekoning dgdekoning deleted the refactor-settings branch October 22, 2019 07:37
@dgdekoning dgdekoning added this to the Version 2.4.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Milestone
Version 2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgdekoning @coveralls