Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings #297

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Refactor settings #297

merged 4 commits into from
Oct 22, 2019

Commits on Oct 18, 2019

  1. Refactor settings code to use subclassing

    @dgdekoning
    dgdekoning committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    4f4f1bd View commit details
    Browse the repository at this point in the history

  2. Refactor code to directly use settings methods

    @dgdekoning
    dgdekoning committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    680b239 View commit details
    Browse the repository at this point in the history

  3. Clean up duplicate settings functions from commontasks

    @dgdekoning
    dgdekoning committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    e4ecad7 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Add tests for refactored settings

    @dgdekoning
    dgdekoning committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    0fd5612 View commit details
    Browse the repository at this point in the history