Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.6.1 #445

Merged
merged 11 commits into from
Sep 27, 2020
Merged

Version 2.6.1 #445

merged 11 commits into from
Sep 27, 2020

Conversation

dgdekoning
Copy link
Contributor

Contains fixes and improvements for the AB.

  • Adds importing of databases through excel.
  • Fixes an issue where exchange flows not used in the LCA matrix caused the calculation to break down.
  • Tweaks and improvements to the database import wizard to improve flow.

* Import from excel

* Add ABExcelImporter class to bwutils

* Add excel import page

* Wire the new page into the database import wizard

* Implement excel exporter for databases
* Move ABPackage class to bwutils

* Add Remote and Local wizard page classes

* Streamline ecoinvent login code

* Unify the design for all pages

* Some function decorators and annotations
* Fix broken import wizard from menu link

* Filter exchange flows that do not exist in the LCA matrix

* Ensure import wizard cannot be clicked out of
@dgdekoning dgdekoning added this to the Version 2.6.1 milestone Sep 22, 2020
@coveralls
Copy link

coveralls commented Sep 22, 2020

Coverage Status

Coverage decreased (-0.3%) to 53.369% when pulling 1ae45cd on 2.6.1 into c84e762 on master.

dgdekoning and others added 7 commits September 23, 2020 10:18
* Add altered version of bw2ip write_lci_excel method

* Return name instead of index for link_db field

* Give the user at least 10 of the unlinked exchanges in the debug console.

* Allow database to be overwritten correctly

* Force reference product existence

* No opening the downstream table on update
* Add signal for relinking

* Extend DatabaseRelinkDialog with another classmethod

* Add strategy for relinking an sqlite database

* Add relinking action to database table and add check for writable database

* Add relink method to controller
* New strategy for the ABExcelImporter

* Customize the automated import method further

* Feed the database name into the importer and signal that params have (possibly) changed

* Add classmethod for asking for any kind of db

* Add excel fixing method for unlinked exchanges

* Add wiring and alter method for linking

* Cleanup of unused code
* Add special export method to ABPackage

* Implement the special export for BW2Package export

* Edit excel exporter to handle given path

* Add browse button and wiring to db export wizard
* Add hashing strategy to avoid group clashes

* Implement the strategy

* Add special linking and relinking strategies

* Automatically suggest same database if in options

* Include set of database names in the StrategyError

* Rework excel fixing method and signal to handle multiple relinking databases

* Implement the strategies for (re)linking
* Ensure previous failed import doesn't impact future one

* Add errors.py to bwutils

* Add special exception to avoid infinite looping

* Catch and show information about the failed linking

* Drop unused method from ABExcelImporter class

* Subclass CSVFormatter, force inclusion of database from input

* Switch CSVFormatter class and drop bw import

* Make db export more intuitive and error resistant
@dgdekoning dgdekoning merged commit a5a6ecd into master Sep 27, 2020
@dgdekoning dgdekoning deleted the 2.6.1 branch October 7, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import option for excel data files Importing Non-ecoinvent LCI from CSVs
2 participants