-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for excel export #451
Merged
dgdekoning
merged 8 commits into
LCA-ActivityBrowser:2.6.1
from
dgdekoning:magical-excel-export
Sep 26, 2020
Merged
Fix for excel export #451
dgdekoning
merged 8 commits into
LCA-ActivityBrowser:2.6.1
from
dgdekoning:magical-excel-export
Sep 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdekoning
added a commit
that referenced
this pull request
Sep 27, 2020
* Excel import and export (#440) * Import from excel * Add ABExcelImporter class to bwutils * Add excel import page * Wire the new page into the database import wizard * Implement excel exporter for databases * Restructure importer code (#442) * Move ABPackage class to bwutils * Add Remote and Local wizard page classes * Streamline ecoinvent login code * Unify the design for all pages * Some function decorators and annotations * Bugfixes (#444) * Fix broken import wizard from menu link * Filter exchange flows that do not exist in the LCA matrix * Ensure import wizard cannot be clicked out of * Add excel exceptions (#443) * Add altered version of bw2ip write_lci_excel method * Return name instead of index for link_db field * Give the user at least 10 of the unlinked exchanges in the debug console. * Allow database to be overwritten correctly * Force reference product existence * No opening the downstream table on update * Database relink after creation (#446) * Add signal for relinking * Extend DatabaseRelinkDialog with another classmethod * Add strategy for relinking an sqlite database * Add relinking action to database table and add check for writable database * Add relink method to controller * [skip ci] Slightly change 7z option text * Overhaul the flow for importing excel files (#447) * New strategy for the ABExcelImporter * Customize the automated import method further * Feed the database name into the importer and signal that params have (possibly) changed * Add classmethod for asking for any kind of db * Add excel fixing method for unlinked exchanges * Add wiring and alter method for linking * Cleanup of unused code * Extend database export wizard (#448) * Add special export method to ABPackage * Implement the special export for BW2Package export * Edit excel exporter to handle given path * Add browse button and wiring to db export wizard * Tweak excel importer (#449) * Add hashing strategy to avoid group clashes * Implement the strategy * Add special linking and relinking strategies * Automatically suggest same database if in options * Include set of database names in the StrategyError * Rework excel fixing method and signal to handle multiple relinking databases * Implement the strategies for (re)linking * [skip ci] Move writing of project parameters * Fix for excel export (#451) * Ensure previous failed import doesn't impact future one * Add errors.py to bwutils * Add special exception to avoid infinite looping * Catch and show information about the failed linking * Drop unused method from ABExcelImporter class * Subclass CSVFormatter, force inclusion of database from input * Switch CSVFormatter class and drop bw import * Make db export more intuitive and error resistant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the excel import would not include a database column for the exchanges.
Include a possible fix for the 'database is deleted' after a successful import problem.
-> This was likely caused by the user canceling an import and the AB then not resetting the 'cancel sentinel', thus causing any future imports to act as though they were also cancelled.
Also include a special exception to avoid the excel import looping infinitely, this will be raised after the first time a (re)link action fails.