Fix issue 20 #58
Merged
Fix issue 20 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptions can include `" .. "` and when these are read, they're converted to `" .."` internally. We need to make sure these are escaped correctly so that when the internal XML string is passed to parsers (like the minidom parser), it is still valid.
These are needed by the regression test for issue 20. We could come up with a regression test that does not require these, or use pyNeuroML to get these on demand, but for the time being I'm checking these in.
If the startup handlers are run before them, then even though the code does initialise variables, it does it in the wrong order. For example, for `v = initMembPot` that is a `StateAssignment` that should happen `OnStart`, `initMembPot` needs to be processed first so that `v` can then pick up its value. Fixes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be merged after #57 has been merged.