Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20 #58

Merged
merged 5 commits into from
Jul 29, 2021
Merged

Fix issue 20 #58

merged 5 commits into from
Jul 29, 2021

Commits on Jul 23, 2021

  1. fix(parser): quote text in the description attribute

    Descriptions can include `" ..  "` and when these are read,
    they're converted to `" .."` internally. We need to make sure these are
    escaped correctly so that when the internal XML string is passed to
    parsers (like the minidom parser), it is still valid.
    sanjayankur31 committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b338399 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13be4dc View commit details
    Browse the repository at this point in the history
  3. chore: add NeuroML LEMS definitions

    These are needed by the regression test for issue 20.
    
    We could come up with a regression test that does not require these, or
    use pyNeuroML to get these on demand, but for the time being I'm
    checking these in.
    sanjayankur31 committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    8d77032 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Configuration menu
    Copy the full SHA
    4b96044 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. fix: run startup handlers after all variables have been processed

    If the startup handlers are run before them, then even though the code
    does initialise variables, it does it in the wrong order. For example,
    for `v = initMembPot` that is a `StateAssignment` that should happen
    `OnStart`, `initMembPot` needs to be processed first so that `v` can
    then pick up its value.
    
    Fixes #20
    sanjayankur31 committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    31c3b46 View commit details
    Browse the repository at this point in the history