Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use loginevent #95

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Use loginevent #95

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2021 •
edited by ghost
Loading

Login event:

  • AntiVPN doesn't need to do mojang lookups when checking permissions
  • AntiVPN can disconnect the player if they are using a VPN before the proxyplayer is loaded (better performance and compatability with plugins)

@ghost ghost changed the title Add support for Waterfall's LoginEvent Use loginevent Feb 22, 2021
egg82
egg82 reviewed Feb 23, 2021
View reviewed changes
Common/src/main/java/me/egg82/antivpn/api/model/source/IPInfo.java
@@ -48,7 +48,7 @@ public IPInfo() {
throw new APIException(true, "Key is not defined for " + getName());
}

WebRequest.Builder builder = getDefaultBuilder("https://ipinfo.io/" + ip + "/privacy?token=" + key, getCachedConfig().getTimeout());
WebRequest.Builder builder = getDefaultBuilder("https://ipinfo.io/" + ip + "?token=" + key, getCachedConfig().getTimeout());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@SrBedrock
Copy link

SrBedrock commented Apr 27, 2021 •
edited
Loading

I've been having problems and I believe that the implementation of these changes would solve my problem, basically it would solve this: https://www.spigotmc.org/threads/formal-petition-to-all-bungeecord-plugin-developers.393041/

[Edit]
This is what happens when I get bot attack even when the anti-bot plugin blocks the bot from entering:
https://gist.github.com/SrBedrock/f00905e3226d19697b1cc6a3d182f437

@SrBedrock SrBedrock mentioned this pull request Apr 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SrBedrock @egg82