-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator and metrics for non-standard date-time display formats #5841
Conversation
…ate parsing... don't use display formats to parse!
…mplement metrics provider.
Suggestion for the formatting of the messages. The "more" link is useful for context, but maybe display the folder path consistently in the message? Also, maybe some formatting for the actual format string to make it stand out. e.g. Instead of Maybe I see that they are actually grouped by folder. So that's nice. |
Adding a non-standard format using edit metadata in the schema browser did not show up in the site validation report. E.g. setting the format for list.xyz.created to yyMMddHHmmssZ |
Yes, they are grouped by folder and project + folder name is listed immediately above each group, so seems redundant to include in every message as well. Site validation messages have never supported HTML... but now they do. See latest commit. Format patterns are now rendered in italics. |
I'll take a look at this... |
…on to custom queries
This should be fixed... please try again |
Rationale
First part of Date/Time formatting simplifications story: https://docs.google.com/document/d/1XcatQe9wRDw1ONLML9x4fFv_fIq9zhXPHoYANBuOykw/edit
Adds a validation provider for non-standard date display formats and a metrics provider that collects & reports all non-standard patterns.
Changes
isStandard*DisplayFormat()
methods. Push standard display formats into client-sideLABKEY
object.ModuleReportResource
date parsing... don't use display formats to parse!