Date/time formatting simplifications #5923
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow empty parsing patterns, fix splitting
…rs from ProjectSettingsForm
…eFolderSettings()
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json
cnathe
approved these changes
Oct 15, 2024
Comment on lines
530
to
533
| // TODO: Delete this block - just for testing | ||
| Set<String> set = new LinkedHashSet<>(options); | ||
| set.add(type == DateDisplayFormatType.Date ? "MM-dd-yyyy" : "kk:mm"); // non-standard | ||
| set.add("xyz"); // invalid |
There was a problem hiding this comment.
just adding a note here to make sure this is removed after testing / before merge.
labkey-adam
commented
Oct 16, 2024
cnathe
approved these changes
Oct 16, 2024
# Conflicts: # biologics/package-lock.json # biologics/package.json # inventory/package-lock.json # inventory/package.json # sampleManagement/package-lock.json # sampleManagement/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Server-side UI changes for https://docs.google.com/document/d/1XcatQe9wRDw1ONLML9x4fFv_fIq9zhXPHoYANBuOykw/edit#heading=h.4rg4h5vuek0
Related Pull Requests
Validator and metrics for non-standard date-time display formats #5841
Date/time formatting simplifications #5923
Datetime formats - app ui labkey-ui-components#1607
https://github.com/LabKey/labkey-ui-premium/pull/563
https://github.com/LabKey/limsModules/pull/826
Changes
LookAndFeelPropertiesmethods that ostensibly retrieved the stored value but actually retrieved inherited values. (Calling the parent class lookup method with a enum inadvertently walked the hierarchy.) Export and inheritance UI should be correct for all settings now.SettingsForm/FolderSettingsForm/ProjectSettingshierarchy: remove pointless SettingsForm interface and have ProjectSettings extend FolderSettings to reduce boilerplatesaveProjectSettings()to take a form instead of JSON