LibWebView: Add Kagi as a search engine to the list of selectable search engines #1126
Conversation
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
mrdcbrush
force-pushed
the
davidbrush
branch
4 times, most recently
from
47fdee1
to
24bacc3
Compare
mrdcbrush
changed the title
| @@ -17,6 +17,7 @@ static constexpr auto builtin_search_engines = Array { | |||
| SearchEngine { "Ecosia"sv, "https://ecosia.org/search?q={}"sv }, | |||
| SearchEngine { "GitHub"sv, "https://github.com/search?q={}"sv }, | |||
| SearchEngine { "Google"sv, "https://www.google.com/search?q={}"sv }, | |||
| SearchEngine { "Kagi"sv, "https://kagi.com/search?q="sv }, | |||
There was a problem hiding this comment.
Should it be this instead?
| SearchEngine { "Kagi"sv, "https://kagi.com/search?q="sv }, | |
| SearchEngine { "Kagi"sv, "https://kagi.com/search?q={}"sv }, |
There was a problem hiding this comment.
Yes it should. Please amend the commit @mrdcbrush. Otherwise this looks good to me.
|
Apologies for the commit storm. |
|
We like to keep the commit history tidy, so this is going to need combining together into one commit. Additionally, there's a merge conflict so you'll need to rebase it on master. This video is very helpful for explaining how to modify existing commits. But feel free to ask here or on the Discord if you get confused. Got takes some getting used to, but it's not so bad after a while. :^) |
|
Okay, I think I got it sorted finally. |
LibWebView: Add Kagi search engine to selection menu
This pull request adds the Kagi search engine as a selectable option on the Settings > Search Engine menu.