Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick 12 ladybird PRs #25378

Merged
merged 19 commits into from
Nov 13, 2024
Merged

Cherry-pick 12 ladybird PRs #25378

merged 19 commits into from
Nov 13, 2024

Conversation

nico
Copy link
Contributor

@nico nico commented Nov 13, 2024

alimpfard and others added 19 commits November 12, 2024 20:12
@alimpfard @nico
LibWasm: Use braces to initialize Reference::Foo classes
4770c83 
These have no declared constructor, so apple clang and clang clang seem
to disagree on some versions.

(cherry picked from commit d2ff92077b2a4ead0a1ef65e7131702e1152cbeb)
@Sebastian-Webster @nico
LibWebView: Add Ecosia search engine
32d7948 
(cherry picked from commit b0e3b289299728583847590209f9ed4b9083bbe3)
@alimpfard @nico
LibWasm: Allow all Value::to<Integral>() calls
d366c52 
This brings back the old behaviour of Value::to<short>() (and other
similar calls), which WASI depends on.
To make sure all similar issues are caught in the future, this commit
also introduces an static assertion in Value::to().

(cherry picked from commit 0d05ab2ad0cc56cc6fe9ee647dfcfda44a92b4f2)
@awesomekling @nico
LibWasm: Make BytecodeInterpreter overrides final
c063192 
This gives us free devirtualization of some hot calls inside the
bytecode interpreter. Most notably the did_trap() checks.

Modest performance improvement on the https://figma.com/ landing page.

(cherry picked from commit 2f3128333dcd5a781f35272800631d6cf03803ad)
@mrdcbrush @nico
LibWebView: Add Kagi search engine to menu
941e8d0 
LibWebView: Add Kagi search engine to selection menu
(cherry picked from commit b757ee0bc8863b7785fe6f5f15ae6d4d3c82896f)
@BramOtte @nico
LibWeb: Handle multiple result values for WebAssembly functions
55ef831 
(cherry picked from commit 003fc4f8eeb57eedba9a6a055002c7fa9d0aab7d)
@BenJilks @nico
LibWeb: Pick the closest hit test result, instead of the first
79e689c 
When performing a hit test of type TextCursor, it would check if the
position is around each fragment and not just inside it. This resulted
in always selecting the first fragment checked.

This commit computes the distance of each hit test result, and picks the
closest one.

(cherry picked from commit 8c465c95aa7acde2355b0ce0762987724f5f6811)
@BenJilks @nico
LibWeb: Test for hits around fragments in InlinePaintable
7897a6f 
This allows you to select text at the end of fragments, just like in
non-inline elements.

(cherry picked from commit 813612096c6135357c9a0e079db67e52900ebd5f)
@trflynn89 @nico
LibWeb: Use a named enum value to generate mousemove button events
9d263bd 
Rather than having to know what 1 means, let's use the enum value.

(cherry picked from commit ae01904369fac96343bf491df1e4860018f20159)
@trflynn89 @nico
LibWeb: Dispatch click events using the correct button/buttons
50fb4d4 
We were generating click events always using the primary mouse button
instead of the provided button, and with the buttons field set to that
provided button.

(cherry picked from commit dd5a0361f2307b280a910d219fbc2dfd0072409f)
@tcl3 @nico
LibWeb: Follow spec steps to set the selectionDirection attribute value
1fb2912 
(cherry picked from commit d0b97873d421d092eb41e3b7a7d8959347b3b436)
@jamierocks @nico
LibWeb: Correct forward for UIEvents::UIEvent
904ba13 
(cherry picked from commit 60d9c3929ccb8334420dc36abddc5665b5955f44)
@jamierocks @nico
LibWeb/UIEvents: Implement InputEvent
d0edee5 
(cherry picked from commit 9fce70069dc29f2232feb8247e69d21fe720fa94)
@jamierocks @nico
LibWeb/UIEvents: Implement CompositionEvent
28ffadc 
(cherry picked from commit 86e20ea2469c0defb6fca40de3cbb339c168b543)
@jamierocks @nico
LibWeb/UIEvents: Implement TextEvent
f6c147f 
(cherry picked from commit f610a12671cccc5bf96c7ce8f7773c02412b8d81)
@gmta @nico
LibCore: Add System::physical_memory_bytes()
d5ddc1f 
(cherry picked from commit 9515290fde3c973226c9737cbd055ebd85df7101)
@gmta @nico
LibWeb: Add WebIDL::Double type
295fc49 
(cherry picked from commit 6189d1ac9d73347638c3cbec4d7e21a390edd238)
@gmta @nico
LibWeb: Implement navigator.deviceMemory
18c5e31 
Fixes at least 2 subtests in wpt/device-memory.

(cherry picked from commit 69f11fc1c657603b189015fd620f96e32adfb9fd)
@sin-ack @nico
LibWeb: Obtain basename before passing base_url to ClassicScript::create
20dfc25 
This would previously crash because it depended on a specific order for
evaluating function arguments, which is undefined.

(cherry picked from commit 27b1d94e04386fd46c2c9148b9555c841595e2d3)
@nico nico requested a review from alimpfard as a code owner November 13, 2024 01:17
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 13, 2024
@nico nico merged commit 3e29a19 into SerenityOS:master Nov 13, 2024
13 checks passed
@nico nico deleted the bulk_sync_1731460323 branch November 13, 2024 03:26
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpfard alimpfard Awaiting requested review from alimpfard alimpfard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.