Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/UIEvents: Implement InputEvent, CompositionEvent, and TextEvent #701

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

jamierocks
Copy link
Contributor

@jamierocks jamierocks commented Jul 18, 2024

Implements some of the missing IDL interfaces from the UI Events spec.

Work towards GH-24168.

Interface Name Status
InputEvent constructor Implemented
InputEvent data Implemented
InputEvent isComposing Implemented
InputEvent inputType Implemented
CompositionEvent constructor Implemented
CompositionEvent data Implemented
CompositionEvent initCompositionEvent Implemented
TextEvent data Implemented
TextEvent initTextEvent Implemented

Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we get some kind of test for these?

@jamierocks
Copy link
Contributor Author

Absolutely 😀 I'll work on this tonight.

@jamierocks jamierocks changed the title LibWeb/UIEvents: Implement InputEvent and CompositionEvent LibWeb/UIEvents: Implement InputEvent, CompositionEvent, and TextEvent Oct 5, 2024
@jamierocks
Copy link
Contributor Author

Since I originally opened this PR, Firefox now implements InputEvent - so I've implemented it here too (without the constructor, per the spec) :)

@awesomekling awesomekling merged commit f610a12 into LadybirdBrowser:master Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants