-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb/UIEvents: Implement InputEvent, CompositionEvent, and TextEvent #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcl3
reviewed
Jul 19, 2024
jamierocks
commented
Jul 22, 2024
AtkinsSJ
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can we get some kind of test for these?
Absolutely 😀 I'll work on this tonight. |
jamierocks
force-pushed
the
input-event
branch
from
October 5, 2024 13:45
76e9c9d
to
12f7b69
Compare
jamierocks
changed the title
LibWeb/UIEvents: Implement InputEvent and CompositionEvent
LibWeb/UIEvents: Implement InputEvent, CompositionEvent, and TextEvent
Oct 5, 2024
jamierocks
force-pushed
the
input-event
branch
from
October 5, 2024 13:48
12f7b69
to
4218f05
Compare
Since I originally opened this PR, Firefox now implements InputEvent - so I've implemented it here too (without the constructor, per the spec) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements some of the missing IDL interfaces from the UI Events spec.
Work towards GH-24168.