Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error for receiver rejection #104

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Add new error for receiver rejection #104

merged 3 commits into from
Jan 12, 2023

Conversation

donpui
Copy link
Contributor

@donpui donpui commented Dec 9, 2022

Add new error message for receiver rejection. Issue #103

@donpui donpui requested a review from JustusFT December 9, 2022 13:25
@donpui
Copy link
Contributor Author

donpui commented Dec 9, 2022

However there is one more thing, we need to fix with this. Now if I get new error messages and press OK, I am still left in the same code page. It should reset/cancel to initial Sending page. Otherwise it looks confusing and requires User to click cancel. @JustusFT we need your help here

@donpui donpui marked this pull request as ready for review January 11, 2023 08:06
JustusFT and others added 2 commits January 12, 2023 09:59
- Updates the wormhole-william submodule which includes the fix for deadlock on cancel.
- Adds reject function to `wormhole.fileMeta` for the receiver. Will cancel the transfer if called before the transfer starts.
  - This replaces the browser refresh workaround previously used for rejection.

Co-authored-by: Donatas Puidokas <[email protected]>
@JustusFT
Copy link
Contributor

@donpui I fixed the reject functionality at #114 , so this pr is ok now 👍

@JustusFT JustusFT merged commit 0b602db into main Jan 12, 2023
@JustusFT JustusFT deleted the 103.error-map branch January 12, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants