-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add receive file rejection functionality #114
Conversation
Assuming fix of w-w part is correct, can we adjust behavior on frontend side, because now only Receiver side initiate rejections, also after rejection on Receiver side, it still stays in the same page (also Sender stays in the same page). |
@donpui I updated this pr so that the sender and receiver resets back to the begin pages when a rejection happens. This pr as well as LeastAuthority/wormhole-william#100 should be ok now. |
CI and for me fails to build:
|
@donpui fixed the type error, it should be ok now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W-W merged and updated submodule. Additionally corrected E2E test to support current behaviour (@JustusFT take a look at last commit, before merging).
* Add new error for receiver rejection - adds an error handler when a transfer is rejected. * Add receive file rejection functionality (#114) - Updates the wormhole-william submodule which includes the fix for deadlock on cancel. - Adds reject function to `wormhole.fileMeta` for the receiver. Will cancel the transfer if called before the transfer starts. - This replaces the browser refresh workaround previously used for rejection. Co-authored-by: Justus Tumacder <[email protected]>
Currently, if the receiver tries to cancel the transfer on the ReceiveConsentScreen, the sender is not notified that the transfer was cancelled. This PR fixes that
Also needs LeastAuthority/wormhole-william#100 to be merged