Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

[LL-7913]Fix isConfirmed operation condition #1526

Merged
merged 1 commit into from
Nov 16, 2021
Merged

[LL-7913]Fix isConfirmed operation condition #1526

merged 1 commit into from
Nov 16, 2021

Conversation

hzheng-ledger
Copy link
Contributor

@hzheng-ledger hzheng-ledger requested a review from a team November 16, 2021 13:51
@vercel
Copy link

vercel bot commented Nov 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/HNYdULvRfc8LVG889cP4QwYf8u57
✅ Preview: https://ledger-live-common-git-ll-7913-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1526 (d92d088) into master (1aaf302) will decrease coverage by 13.17%.
The diff coverage is 0.00%.

❗ Current head d92d088 differs from pull request most recent head e30f19f. Consider uploading reports for the commit e30f19f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1526       +/-   ##
===========================================
- Coverage   68.01%   54.84%   -13.18%     
===========================================
  Files         534      503       -31     
  Lines       22117    20138     -1979     
  Branches     5341     4979      -362     
===========================================
- Hits        15043    11044     -3999     
- Misses       6980     9049     +2069     
+ Partials       94       45       -49     
Impacted Files Coverage Δ
src/operation.ts 67.04% <0.00%> (-4.55%) ⬇️
src/libcore/createAccountFromDevice.ts 8.82% <0.00%> (-91.18%) ⬇️
src/families/elrond/api/apiCalls.ts 14.28% <0.00%> (-82.86%) ⬇️
src/families/algorand/libcore-buildSubAccounts.ts 16.36% <0.00%> (-81.82%) ⬇️
src/families/algorand/libcore-buildOperation.ts 15.62% <0.00%> (-81.25%) ⬇️
src/families/cosmos/libcore-buildOperation.ts 4.83% <0.00%> (-80.65%) ⬇️
src/libcore/buildAccount/index.ts 14.58% <0.00%> (-80.21%) ⬇️
src/families/cosmos/libcore-mergeOperations.ts 13.63% <0.00%> (-77.28%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.87% <0.00%> (-76.57%) ⬇️
src/families/elrond/api/sdk.ts 23.07% <0.00%> (-75.00%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aaf302...e30f19f. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants