Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-886 (Market): add sparkline variation + fix issue in countervalue initial value #1700

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Feb 14, 2022

  • (Market): add svg sparkline variation + fix issue in countervalue initial setting

Context (issues, jira)

LIVE-886

Description / Usage

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@LFBarreto LFBarreto requested a review from a team as a code owner February 14, 2022 08:12
@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/9CcZSKLWqtJ5rUgL9byZK4MXwBPe
✅ Preview: https://ledger-live-common-git-live-886-ledgerhq.vercel.app

@LFBarreto LFBarreto changed the base branch from master to develop February 16, 2022 09:16
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1700 (69d7278) into develop (9763372) will increase coverage by 3.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1700      +/-   ##
===========================================
+ Coverage    51.07%   54.80%   +3.73%     
===========================================
  Files          516      582      +66     
  Lines        22189    22765     +576     
  Branches      5310     5662     +352     
===========================================
+ Hits         11332    12476    +1144     
+ Misses       10799    10240     -559     
+ Partials        58       49       -9     
Impacted Files Coverage Δ
src/libcore/createAccountFromDevice.ts 8.82% <0.00%> (-91.18%) ⬇️
src/families/cosmos/libcore-mergeOperations.ts 13.04% <0.00%> (-78.27%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/libcore/buildAccount/index.ts 14.43% <0.00%> (-76.29%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-75.29%) ⬇️
src/families/bitcoin/js-signOperation.ts 20.89% <0.00%> (-74.63%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/crypto_org/js-signOperation.ts 19.40% <0.00%> (-71.65%) ⬇️
src/families/solana/js-broadcast.ts 28.57% <0.00%> (-71.43%) ⬇️
... and 369 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9763372...69d7278. Read the comment docs.

@LFBarreto LFBarreto merged commit 96c31e5 into develop Feb 18, 2022
@LFBarreto LFBarreto deleted the LIVE-886 branch February 18, 2022 13:36
@BenAffleck BenAffleck mentioned this pull request Mar 6, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant