Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-886 (Market): add sparkline variation #4738

Merged
merged 1 commit into from
Feb 18, 2022
Merged

LIVE-886 (Market): add sparkline variation #4738

merged 1 commit into from
Feb 18, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Feb 14, 2022

  • (Market): update sparkline color according to variation

🦒 Context (issues, jira)

LIVE-886

💻 Description / Demo (image or video)

sparkline mini chart should reflect variation with color green and red.

should automatically work once LedgerHQ/ledger-live-common#1700
is merged and integrated within LLD

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

@LFBarreto LFBarreto requested a review from a team as a code owner February 14, 2022 09:23
@LFBarreto LFBarreto changed the title LIVE-886 LIVE-886 (Market): add sparkline variation Feb 14, 2022
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 879c557

@LFBarreto LFBarreto merged commit 518dd06 into develop Feb 18, 2022
@LFBarreto LFBarreto deleted the LIVE-886 branch February 18, 2022 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants